283603 - The "tab"-icon in Options is the same as download-icon

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050225
Firefox/1.0+

Open new options window
The tab "icon" is the same as the download icon

Comment 1

[Steve England [:stevee]]

*** Bug 283599 has been marked as a duplicate of this bug. ***

Comment 2

[Tom Hessman]

On Mac OS X, it shows the General icon, the Privacy icon, the Content icon, the
Themes icon, the Extensions icon, the Advanced icon, and the Downloads
icon...all next to each other as one entity for "Tabs"!  I was pretty confused
at first...

Comment 3

[Mark Mentovai]

Attachment: How it looks on Mac OS X

What it looks like on Mac OS X.  Assuming it's a different (and worse)
manifestation of the same bug.

Comment 4

[Peter van der Woude [:Peter6]]

If you use the default theme you may need to file another bug.

A number of these icons obviously don't belong there at all.

This bug is only about the use of the download icon for both "tabs" and "downloads"

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The image that is used in that case doesn't even have an image defined for tabs.

See:
http://lxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/preferences/Options.png

So the image region for the downloads:
http://lxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/preferences/preferences.css#65

Is the same as the one for tabs:
http://lxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/preferences/preferences.css#72

A new image needs to be added and the regions modified accordingly.

The same base cause affects the mac theme, with different results since the
image regions are different as well as the image:

http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/preferences/Options.png

Comment 6

[Peter van der Woude [:Peter6]]

CC Stephen Horlander for missing image

Comment 7

[Mike Connor [:mconnor]]

this is really a theme issue.  I think ben hacked in the download icon as a
placeholder, but missed pinstripe, but I'm sure he's already poked Steven/Kevin.
 In any case, tossing to Kevin so its on the right person's radar.

Comment 8

[Piotr Komoda]

The patch for MacOS X problem(s) has already been checked in, but only for
PREFERENCES_20050101_BRANCH, not for trunk.

Comment 9

[Kevin Gerich]

I just checked in the Mac theme tweaks to the trunk. I'll work on a Winstripe
Tabs icon this weekend.

Comment 10

[Stephen Horlander [:shorlander]]

(In reply to comment #9)
> I just checked in the Mac theme tweaks to the trunk. I'll work on a Winstripe
> Tabs icon this weekend.

Can't we just use the Tab icon we have minus the + sign?

Comment 11

[Wesley Johnston (:wesj)]

Attachment: Preferences dialog images with Tab Icon

Dang, the more I think about this the more pointless it seems to file, but
here's an updated Icon. Just stole the new tab icon and edited it a bit. Tkae
it or leave it. I don't have access to CVS, so I can't create the patch for
preferences.css but the changes should involve changing the file at:
classic.jar\skin\classic\browser\preferences\preferences.css so that the tabs
pane reads:

radio[pane=paneTabs] {
	-moz-image-region: rect(0px, 192px, 32px, 160px)
}
radio[pane=paneTabs]:hover, radio[pane=paneTabs][selected="true"] {
	-moz-image-region: rect(32px, 192px, 64px, 160px)
}

if someone else can create it.

Comment 12

[Kevin Gerich]

Checked in a tabs icon and the image rect coords to use it. I haven't had a
chance to test this on Windows. Please post a screenshot here.. thanks.

Comment 13

[Asaf Romano (gone)]

Attachment: screenshot

Comment 14

[Peter van der Woude [:Peter6]]

Attachment: modified icon

Kevin, the tabs icon doesn't "fit" too well in the row (not enough height)
I stretched the image a bit (top row of att.) to make it fit better.
Could you modify it when you have the time (and before too many start
complaining )

Comment 15

[Worcester12345]

(In reply to comment #14)
> Created an attachment (id=176560) [edit]
> modified icon
> 
> Kevin, the tabs icon doesn't "fit" too well in the row (not enough height)
> I stretched the image a bit (top row of att.) to make it fit better.
> Could you modify it when you have the time (and before too many start
> complaining )
> 

That is an improvement, but I think the best would be somewhere in the middle.
The "tab" part is now too tall, but the "folder part" could be the enlarged part.

Comment 16

[Kevin Gerich]

Attachment: Second pass at Tabs icon .. checked in

Comment 17

[Peter van der Woude [:Peter6]]

thanks Kevin

Comment 18

[Worcester12345]

(In reply to comment #16)
> Created an attachment (id=176963) [edit]
> Second pass at Tabs icon .. checked in
> 

Nice!

Comment 19

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change