User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b2) Gecko/20050221 Firefox/1.0+ Build Identifier: Since all our rendering goes thru the nsAppshell thread it should be set to B_DISPLAY_PRIORITY Reproducible: Always Steps to Reproduce:
Created attachment 175553 [details] [diff] [review] Set priority in Run r?
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Attachment #175553 - Flags: review?(sergei_d)
I hope this is first step in adjusting things. Now it sets display priority for thread with name mozilla-bin, as i remember, you planned to create entirely separate thread for event-handling. Also we should consider to decrease some priorities. High priority != "always good". I remember how i made early VLC much more smooth when lowered thread priority for most CPU-consuming threads, namely - decoders threads. Maybe some background actions like networking or rendering on inactive pages should get lower priorities, while highest remains for active window/tab events. Maybe we can manage part of that that in nsWindow code, in CallMethod::ACTIVATE for example.
Comment on attachment 175553 [details] [diff] [review] Set priority in Run r=sergei_d Let's go. Hope it isn't last patch on that topic. Though, testing on low-end machines for coming group of changes is very welcomed
Attachment #175553 - Flags: review?(sergei_d) → review+
Checked in. nsAppShell.cpp new revision: 1.29; previous revision: 1.28
Additional patches needed, coz all windows and all "no-name" threads do inherit this display priority, which, i think, it is not what was intended.
egh, those priorities were "os-defaults", so annihilating previous comment
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.