[BEOS] nsAppshell run should be B_DISPLAY_PRIORITY

RESOLVED FIXED

Status

Core Graveyard
GFX: BeOS
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: tqh, Assigned: tqh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b2) Gecko/20050221 Firefox/1.0+
Build Identifier: 

Since all our rendering goes thru the nsAppshell thread it should be set to
B_DISPLAY_PRIORITY

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

13 years ago
Created attachment 175553 [details] [diff] [review]
Set priority in Run

r?
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Attachment #175553 - Flags: review?(sergei_d)
(Assignee)

Updated

13 years ago
Blocks: 266252

Comment 2

13 years ago
I hope this is first step in adjusting things.
Now it sets display priority for thread with name mozilla-bin,
as i remember, you planned to create entirely separate thread for event-handling.

Also we should consider to decrease some priorities. High priority != "always good".

I remember how i made early VLC much more smooth when lowered thread priority for 
 most CPU-consuming threads, namely - decoders threads.

Maybe some background actions like networking or rendering on inactive pages
should get lower priorities, while highest remains for active window/tab events.

Maybe we can manage part of that that in nsWindow code, in CallMethod::ACTIVATE
for example.

Comment 3

13 years ago
Comment on attachment 175553 [details] [diff] [review]
Set priority in Run

r=sergei_d

Let's go. Hope it isn't last patch on that topic.
Though, testing on low-end machines for coming group of changes is very
welcomed
Attachment #175553 - Flags: review?(sergei_d) → review+

Comment 4

13 years ago
Checked in.
nsAppShell.cpp
new revision: 1.29; previous revision: 1.28 

Comment 5

13 years ago
Additional patches needed, coz all windows and all "no-name" threads do inherit
this display priority, which, i think, it is not what was intended.

Comment 6

13 years ago
egh, those priorities were "os-defaults", so annihilating previous comment
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.