283854 - New quit dialog for ChatZilla

Status: RESOLVED DUPLICATE of bug 227093

(Other Applications :: ChatZilla, defect)

Description

[Oriyan Hermoni]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

ChatZilla needs a new confirmation dialog for when accidently closing it.

Reproducible: Always

Steps to Reproduce:
1. Start ChatZilla
2. Click on the X button (X on windows linux, red button on mac)
Actual Results:  
ChatZilla closes without warning.

Expected Results:  
Should ask whether you want to actually close it.

Comment 1

[Oriyan Hermoni]

Attachment: Added a confirmation dialog.

This patch adds a confirmation dialog.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Hardcoding the string doesn't allow for localization. You can see examples of
how it needs to be done using lxr.

http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/message-manager.js
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/locale/en-US/chatzilla.properties

Comment 3

[James Ross]

As an example of the localisation in work, see:

http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/locale/en-US/chatzilla.properties#912
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/handlers.js#127

Notice the special munging that occurs. "msg.closing" --> "MSG_CLOSING".

Also, the code needs to follow the style guide here:
  http://www.hacksrus.com/~ginda/pedant.html

This is also a dup of bug 227093.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Indeed.

*** This bug has been marked as a duplicate of 227093 ***