284084 - Setting both "ask before sanitizing" and "sanitize on shutdown" opens a broken sanitize window on shutdown

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[PikeUK]

If you tell Firefox to ask before sanitizing and to sanitize on shutdown, the
resulting dialog is broken.

Steps to reproduce:
1. Goto Tools->Options->Privacy->Sanitize Settings.
2. Select both "Sanitize Firefox on shutdown" and "Ask before Sanitizing Firefox".
3. Shutdown Firefox.

Actual results
A sanitize window appears which has none of the checkboxes prefilled and a
non-working OK button.

Expected results
A working sanitize box should appear.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050228 Firefox/1.0+

Comment 1

[u88484]

Confirming
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050228
Firefox/1.0+

OS=ALL please

Comment 2

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050301
Firefox/1.0+

The under options selected checkboxes are grayed out.
The sanitize button is grayed out

expected:
1. show boxes checked / unchecked
2. gray out all options (maybe not ?)
3. working sanitize button

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Landed. (a few days ago).

Comment 5

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change