Closed Bug 284273 Opened 15 years ago Closed 15 years ago

Move productResponsibilities from editusers.cgi to Bugzilla::User.pm

Categories

(Bugzilla :: Administration, task, P3)

2.19.2

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: Wurblzap, Assigned: Wurblzap)

References

Details

Attachments

(1 file, 1 obsolete file)

(In reply to bug 119485, comment #36)
> >+# Retrieve product responsibilities, usable for both display and verification.
> >+sub productResponsibilities {
> 
>   We should probably have this in Bugzilla::User, so it will be easier to
> update if we ever create more "responsibilities" for the user.
Attached patch Patch (obsolete) — Splinter Review
Very straightforward.
Attachment #179868 - Flags: review?
Status: NEW → ASSIGNED
Severity: normal → enhancement
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 179868 [details] [diff] [review]
Patch

Yeah, very straightforward. :-)

The code is fine. But the POD docs need a description of the return format.

Also, we should really have a cache for this information just like we have for
all the other functions. ($self->{product_responsibilities})
Attachment #179868 - Flags: review? → review-
Attached patch Patch 2Splinter Review
o Has a cache now.
o Nice POD.
o Removed responsibility hash from confirm-delete interface because it's now
part
  of the user object.
Attachment #179868 - Attachment is obsolete: true
Attachment #187133 - Flags: review?(mkanat)
Comment on attachment 187133 [details] [diff] [review]
Patch 2

Yep, this looks quite good on inspection. You've tested it?
Attachment #187133 - Flags: review?(mkanat) → review+
> You've tested it?

Yes, I tested

1 deleting a user without responsibilites
2 trying to delete a user
  2.1 with one responsibility
  2.2 being initial owner and initial QA contact in the same product
  2.3 being initial owner for several products, and initial QA contact for
      several products
3 trying to delete a user even though the confirm-delete template tries to keep
  me from doing it by not displaying the "delete" button
Flags: approval?
under normal circumstances, I would say to hold this for 2.22, but since it's
blocking stuff that needs to go in 2.20, I guess it can go in :)
Flags: approval? → approval+
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.90; previous revision: 1.89
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.57; previous revision: 1.56
done
Checking in template/en/default/admin/users/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.