284331 - SHGetMalloc API call is deprecated (in nsXREDirProvider.cpp)

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[David Gardiner]

According to the MSDN documentation
(http://msdn.microsoft.com/library/en-us/shellcc/platform/shell/reference/functions/shgetmalloc.asp)

"This function should no longer be used. Use the CoTaskMemFree and
CoTaskMemAlloc functions in its place"

This is used in:
/toolkit/xre/nsXREDirProvider.cpp, line 598 -- if
(!SUCCEEDED(SHGetMalloc(&pMalloc)))

I hope I picked the right component - this was the only one I could find for XRE.

-dave

Comment 1

[David Gardiner]

Attachment: Use CoTaskMemFree to release memory

Comment 2

[Darin Fisher]

Comment on attachment 176126 [details] [diff] [review]
Use CoTaskMemFree to release memory

>Index: nsXREDirProvider.cpp

>-  LPMALLOC pMalloc;
>   LPITEMIDLIST pItemIDList = NULL;
> 
>   if (!SUCCEEDED(SHGetMalloc(&pMalloc)))
>     return NS_ERROR_OUT_OF_MEMORY;

shouldn't you remove this line too?

Comment 3

[David Gardiner]

Attachment: Use CoTaskMemFree to release memory

Comment 4

[Caleb]

Comment on attachment 184475 [details] [diff] [review]
Use CoTaskMemFree to release memory

Requesting approval for this minor change.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Seems as though this was never checked in, I'm assuming the branch approval is
no longer valid. Darin, did you want to check this in on the trunk?

Comment 6

[Darin Fisher]

fixed-on-trunk

yeah, hard for me to keep track of these things when their not assigned to me :-(
i'm not going to bother fixing this on the 1.8 branch.