284512 - right click triggers window onclick handler

Status: RESOLVED INVALID

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Scott MacVicar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 firefox/1.0

Was partially fixed by bug #71705
They prevented right clicking trigger element onclick events but it seems to
still be triggering the document onclick.

See testcase

Reproducible: Always

Comment 1

[Scott MacVicar]

Attachment: Testcase

Comment 2

[Alex Vincent [:WeirdAl]]

Either this bug or bug 284512 is invalid.  They can't both be valid...

Comment 3

[Scott MacVicar]

The other is invalid according to bug #71705

Comment 4

[Alex Vincent [:WeirdAl]]

Re comment 2:  ah, oops, I meant bug 284482.

Comment 5

[Boris Zbarsky [:bzbarsky]]

We probably need to hack nsGlobalWindow::HandleDOMEvent the same way as generic
element was hacked in bug 71705.  Do we need to hack document too?

Or is this all a non-issue?  The code in bug 71705 was put in place to work
around a very common issue with event handlers on links.  There is no such issue
with event handlers on documents and windows.

Comment 6

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 7

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 8

[Kevin Ar18]

Attachment: Bubble Testcase

Here is another testcase that might help explain it.

Basically, "onclick" was removed for right click on all objects, except document, window, & browser chrome.  (Bug 71705#50)
However, because onclick is still enabled on document, it sometimes causes problems for complex programs that work with bubbling or capture - like vBulletin.  Should we disable onclick for document in webpages to be consistent or is there a range of webpages that now rely on this quirk?

Comment 9

[Kevin Ar18]

Attachment: Bubble Testcase

Update/Fix

Comment 10

[Kevin Ar18]

Attachment: Bubble Testcase

One last try to get it to work. Wrong mime-type. Sorry.

Comment 11

[Josh Matthews [:jdm]]

I see

type: click
target: HTMLDivElement(id=div2)
eventPhase: 1  currentTarget: HTMLDocument	eventTarget: HTMLDivElement
eventPhase: 1  currentTarget: HTMLHtmlElement	eventTarget: HTMLDivElement
eventPhase: 1  currentTarget: HTMLBodyElement	eventTarget: HTMLDivElement
eventPhase: 1  currentTarget: HTMLDivElement	eventTarget: HTMLDivElement  id == div1
eventPhase: 2  currentTarget: HTMLDivElement	eventTarget: HTMLDivElement  id == div2
eventPhase: 2  currentTarget: HTMLDivElement	eventTarget: HTMLDivElement  id == div2
eventPhase: 3  currentTarget: HTMLDivElement	eventTarget: HTMLDivElement  id == div1
eventPhase: 3  currentTarget: HTMLBodyElement	eventTarget: HTMLDivElement
eventPhase: 3  currentTarget: HTMLHtmlElement	eventTarget: HTMLDivElement
eventPhase: 3  currentTarget: HTMLDocument	eventTarget: HTMLDivElement

vs

type: click
target: HTMLDivElement(id=div2)
eventPhase: 1  currentTarget: HTMLDocument	eventTarget: HTMLDivElement
eventPhase: 3  currentTarget: HTMLDocument	eventTarget: HTMLDivElement

for left vs. right on the latest testcase.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

What do other browsers do. Do they trigger click event handler on all the event targets?

Note, there have been contradicting requests, either to have right click to trigger click listeners
or not trigger.

Comment 13

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Happily reporting that this can't be reproduced anymore.