Closed
Bug 284555
Opened 18 years ago
Closed 17 years ago
Menu text color remains -moz-menuhovertext when popup a dialog
Categories
(Core Graveyard :: GFX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(2 files, 1 obsolete file)
72.23 KB,
image/jpeg
|
Details | |
810 bytes,
patch
|
aaronlev
:
review+
roc
:
superreview+
roc
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
I'm using GTK2 20050217 nightly build. Try Edit->Preferences The color of "Edit" in top menu remains -moz-menuhovertext. It should be color MenuText.
With 20050302 nightly build Preferences dialog is changing. But this bug is still exsit with File->Page Setup
Comment 4•18 years ago
|
||
Ginn, can you do me a favor and take this one? The bug doesn't occur on Windows and it will take me a while to get a Linux machine going again. Sorry for the regression. Also, Kyle said you enjoy fixing the bugs I cause :)
Assignee: aaronleventhal → ginn.chen
Backing out this line solved this bug, but I don't know if it will break bug 281568 again.
Attachment #177838 -
Flags: review?(aaronleventhal)
Aaron, I just tested my patch on Windows with MSAA. Here's the result. 1) Before fixing of bug 281568, the event sequence is MENUSTART MENUPOPUPSTART Click 'Cancel' MENUPOPUPEND MENUEND 2) Nightly trunk, the event sequence is MENUSTART MENUPOPUPSTART MENUPOPUPEND MENUEND Click 'Cancel' 3) Use my patch to back out 1 line, the event sequence is MENUSTART MENUPOPUPSTART MENUPOPUPEND Click 'Cancel' MENUEND Do you think the sequence 3) is right?
Attachment #177838 -
Attachment is obsolete: true
Attachment #177838 -
Flags: review?(aaronleventhal)
Use ToggleMenuActiveState() instead of just SetActive(PR_TRUE), so that the menu will be deactivated correctly. The 'if (mIsActive)' is needless, put it here just in case.
Attachment #190809 -
Flags: review?(aaronleventhal)
(In reply to comment #6) > Do you think the sequence 3) is right? The sequence 3) is wrong. So I made another patch. I've tested on Linux and Windows. It fixes this bug and doesn't take bug 281568 back. Aaron, please review it.
Status: NEW → ASSIGNED
Comment 9•17 years ago
|
||
Comment on attachment 190809 [details] [diff] [review] patch It looks okay, because ToggleMenuActiveState() just does the same thing as SetActive() but also closes any open submenu.
Attachment #190809 -
Flags: review?(aaronleventhal) → review+
Comment 10•17 years ago
|
||
BTW, I tested with a screen reader on Windows and going into a dialog from a menu still reads correctly, so this fix definitely doesn't break bug 281568.
Assignee | ||
Comment 11•17 years ago
|
||
Comment on attachment 190809 [details] [diff] [review] patch Thank you, aaron. Neil, since you superreviewed patch of bug 281568, please sr this again. Thanks.
Attachment #190809 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #190809 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview?(roc)
Attachment #190809 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 12•17 years ago
|
||
Checking in xul/base/src/nsMenuBarFrame.cpp; /cvsroot/mozilla/layout/xul/base/src/nsMenuBarFrame.cpp,v <-- nsMenuBarFrame.cpp new revision: 1.135; previous revision: 1.134 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
QA Contact: bugzilla → general
Assignee | ||
Comment 13•17 years ago
|
||
Comment on attachment 190809 [details] [diff] [review] patch It still happens when pops up "Confirm close" dialog on MOZILLA_1_8_BRANCH.
Attachment #190809 -
Flags: approval-branch-1.8.1?(roc)
Attachment #190809 -
Flags: approval-branch-1.8.1?(roc) → approval-branch-1.8.1+
Assignee | ||
Comment 14•17 years ago
|
||
Checking in xul/base/src/nsMenuBarFrame.cpp; /cvsroot/mozilla/layout/xul/base/src/nsMenuBarFrame.cpp,v <-- nsMenuBarFrame.cpp new revision: 1.131.14.3; previous revision: 1.131.14.2 done
Keywords: fixed1.8.1
Updated•14 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•