284704 - Brushes are deleted by SolidBrushCache in gfx\src\windows\nsRenderingContextWin.cpp when possibly still in use

Status: RESOLVED EXPIRED

(Core Graveyard :: GFX: Win32, defect)

Description

[David Gardiner]

I'm wondering if there's a potential problem with the way the SolidBrushCache works.

It appears to be a single cache for the entire application that holds up to 17
GDI brushes.

The problem I'm worried about is that when the cache is full, the oldest brush
is just deleted (using ::DeleteObject()), however there is no check done to see
if that brush is currently selected in any device contexts.

The docs for DeleteObject
(http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/devcons_1vsk.asp)
include the remark "Do not delete a drawing object (pen or brush) while it is
still selected into a DC."

I wonder if the brush cache should somehow be smarter, maybe there should only
be a brush cache per DC, or maybe we should do away with the brush cache all
together.

On the other hand, maybe I'm worry about nothing.

-dave

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.