284929 - File -> Open Location nonfunctional when the Location Toolbar is hidden

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[Miriam Frenay]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

When the Location Toolbar is hidden (e.g. in a javascript popup) the File ->
Open Location menu item does not display the Open Web Location dialog.

Reproducible: Always

Steps to Reproduce:
1. Set the dom.disable_window_open_feature.menubar preference to true
2. Open a javascript link that opens a new window with the location toolbar hidden
3. Select the File -> Open Location menu item

Actual Results:  
Nothing

Expected Results:  
Display the Open Web Location dialog

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Where does "display: none" ever get set on the toolbar? Isn't it the result of
having "moz-collapsed" or "chromehidden" attributes, or something else that you
can use instead of getting the computed style?

Comment 3

[Asaf Romano (gone)]

Gavin, the chromehidden attribute "produces" display:none, see relevant rules in
xul.css (and no, it doesn't affect the collapsed property)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> Gavin, the chromehidden attribute "produces" display:none

Right, so why don't you use |hasAttribute("chromehidden")| then? That seems
cleaner to me, and probably is less expensive than computing the style.

Am I missing something?

Comment 5

[Asaf Romano (gone)]

(In reply to comment #4)
> (In reply to comment #3)
> > Gavin, the chromehidden attribute "produces" display:none
> 
> Right, so why don't you use |hasAttribute("chromehidden")|

chromehidden doesn't store the location bar status alone, you'll need to pass it
in a regexp.

> and probably is less expensive than computing the style.

no, it isn't.

Comment 6

[Asaf Romano (gone)]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.402; previous revision: 1.401
done