285065 - Firefox preferences window leaks global object due to radio.xml cycle

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The Firefox preferences window leaks its global object (and thus that of the
window that opened it) because there's a cycle through C++ objects created by
radio.xml:  the |iterator| variable is in the scope that's visible to
|_filterRadioGroup|, which is owned by the iterator.

(I'm thinking somebody should do a memory leak audit of these widgets...)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2005-03-06 20:36 -0800.

Comment 3

[[e-mail]]

Comment on attachment 176533 [details] [diff] [review]
patch

>+          // XXX The function really should be global instead of local.
Do you mean as per attachment 134317 [details] [diff] [review]'s _filterRadioGroup method?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #3)
> (From update of attachment 176533 [details] [diff] [review])
> >+          // XXX The function really should be global instead of local.
> Do you mean as per attachment 134317 [details] [diff] [review]'s _filterRadioGroup method?

Yes.

Comment 5

[[e-mail]]

Attachment: Fix XXX

Comment 6

[[e-mail]]

I actually patched revision 1.15 of tookit's radio.xml ;-)

Comment 7

[Jesse Ruderman]

See also bug 323534, "createTreeWalker can cause leaks due to cycles created by closures".

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FWIW, bug 323534 removed the need for this patch.