285140 - [FIX]if user stylesheet has "br{ display: none; }", the line of the content of textarea element is not break by LF

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If user stylesheet has following code, the line of the content of textarea
element is not break by LF.

br{
  display: none;
}

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

the content of textarea should be 

line1
line2
line3
line4
line5

but, if user stylesheet has "br{ display: none; }", it is as following text.

line1line2line3line4line5

Comment 3

[Boris Zbarsky [:bzbarsky]]

Why are we even applying the user stylesheet to content in a textarea? 
Shouldn't that be anonymous content?

Comment 4

[Hixie (not reading bugmail)]

this is a dup, anyway

Comment 5

[Christian Reis]

A dupe of which bug, Hixie?

Comment 6

[Hixie (not reading bugmail)]

If I knew which one, I'd have marked it. :-) There is a long standing bug about
<br> and <textarea> though.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 286895.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No, I can still reproduce this bug.

Comment 9

[Boris Zbarsky [:bzbarsky]]

On trunk?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

of course, 2007060304 on winxp.

Comment 11

[Boris Zbarsky [:bzbarsky]]

I can't reproduce.  If I add:

  br { display: none }

to my userContent.css, with a trunk build I see no <br> in normal HTML, but I do see linebreaks in the testcase attached to this bug.

Please attach your user stylesheet to the bug?  And double-check that you really are testing a trunk build and not running into xremote or anything like that?

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot with 2007060405

I only added "br {display: none;}" for testing. (my userContent.css only had this rule.)

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

the screenshot was with safe mode.

Comment 14

[Boris Zbarsky [:bzbarsky]]

How odd.  I can reproduce this with one of my trees, but not another one...

And it definitely should NOT be happening. I wonder what's up.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Oh, I see.  One of my trees doesn't have the <br> in textareas.

So I guess the real issue is that those <br>s are not actually native anonymous.  Fix coming up.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 267246 [details] [diff] [review]
Like so

r=sr=dbaron if you make the method class-static or file-static -- I don't see why it needs a |this|.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Made the method class-static and checked in.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v.