Add Bookmark sheet confirmation button uses "OK" rather than "Add"

RESOLVED FIXED in Camino1.0

Status

--
trivial
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: danielwilson, Assigned: camino)

Tracking

unspecified
Camino1.0
PowerPC
macOS

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+

Camino's "Add Page to Bookmarks…" sheet (as of the March 4, 2005 build) uses
"OK" for the confirmation button rather than "Add", the term used in Safari,
Firefox, and OmniWeb.

Reproducible: Always
(Assignee)

Comment 1

14 years ago
Valid request. I think it would help indeed. I'll have a look myself at this one.
Assignee: pinkerton → camino
Target Milestone: --- → Camino1.0
(Assignee)

Updated

14 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
While we're at it, if this is gonna get changed, might as well replace "Cancel"
with "Don't Add" -- Jef Raskin would approve ;)

cl
I think "Cancel" is a valid name for the button that cancels.

Comment 4

14 years ago
(In reply to comment #3)
> I think "Cancel" is a valid name for the button that cancels.

Cancel may be valid but "Don't Add" is clearer and compliments theother commend
of "Add Bookmark" better.

Tried to create an attachment of a fixed NIB file, but it's not liking me.
Jasper, I'll e-mail the NIB file to you, and we can go from there.

cl
(Assignee)

Comment 6

14 years ago
Posted file New addBookmark.nib
This new one contains the "Add" and "Don't Add" buttons instead of OK and
Cancel.

Chris, all you need to do to attach a .nib is to make sure you zip it some way
or another. Remember that a .nib is just a folder and you just can't attach a
folder to bugzilla.
All right, now that we have the nib done, someone want to review it?

Thx for the reminder, Jasper. I had forgotten about that. ;)

cl
buttons are now "Add" and "Cancel". We should stick with cancel, it's what the
OS does all over the place (including safari). 
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.