285528 - Add Bookmark sheet confirmation button uses "OK" rather than "Add"

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Daniel Wilson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+

Camino's "Add Page to Bookmarks…" sheet (as of the March 4, 2005 build) uses
"OK" for the confirmation button rather than "Add", the term used in Safari,
Firefox, and OmniWeb.

Reproducible: Always

Comment 1

[Jasper]

Valid request. I think it would help indeed. I'll have a look myself at this one.

Comment 2

[Chris Lawson (gone)]

While we're at it, if this is gonna get changed, might as well replace "Cancel"
with "Don't Add" -- Jef Raskin would approve ;)

cl

Comment 3

[Wevah (Nate Weaver)]

I think "Cancel" is a valid name for the button that cancels.

Comment 4

[Steve Ruge]

(In reply to comment #3)
> I think "Cancel" is a valid name for the button that cancels.

Cancel may be valid but "Don't Add" is clearer and compliments theother commend
of "Add Bookmark" better.

Comment 5

[Chris Lawson (gone)]

Tried to create an attachment of a fixed NIB file, but it's not liking me.
Jasper, I'll e-mail the NIB file to you, and we can go from there.

cl

Comment 6

[Jasper]

Attachment: New addBookmark.nib

This new one contains the "Add" and "Don't Add" buttons instead of OK and
Cancel.

Chris, all you need to do to attach a .nib is to make sure you zip it some way
or another. Remember that a .nib is just a folder and you just can't attach a
folder to bugzilla.

Comment 7

[Chris Lawson (gone)]

All right, now that we have the nib done, someone want to review it?

Thx for the reminder, Jasper. I had forgotten about that. ;)

cl

Comment 8

[Mike Pinkerton (not reading bugmail)]

buttons are now "Add" and "Cancel". We should stick with cancel, it's what the
OS does all over the place (including safari).