The default bug view has changed. See this FAQ.

Pressing the Escape key does not close the preferences window

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
--
trivial
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Daniel Wilson, Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1, polish})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1, polish

Details

Attachments

(1 attachment)

1003 bytes, patch
Wevah
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+

In a number of applications (iChat, Mail, iCal), pressing the Escape key closes
the preferences window.

Reproducible: Always

Steps to Reproduce:
1. Open Preferences window.
2. Press Escape.

Actual Results:  
Error beep.

Expected Results:  
Closed the Preferences window.

Comment 1

12 years ago
I guess this is a valid enhancement request. Not a priority.
Target Milestone: --- → Camino1.2

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: Camino1.2 → Camino1.0

Comment 2

12 years ago
Not a priority, but an extremely easy fix: Simply change the class of the window
from NSWindow to NSPanel in the nib.
QA Contact: bugs.mano
(In reply to comment #2)
> Not a priority, but an extremely easy fix: Simply change the class of the
> window from NSWindow to NSPanel in the nib.

That won't have any adverse affects on other expected behavior/code, will it?  If not, this looks like some really simple polish we could add.
Keywords: polish

Comment 4

12 years ago
It shouldn't cause any problems, unless we're referencing [NSApp mainWindow] in a prefpane somewhere.

Comment 5

11 years ago
(In reply to comment #4)
> It shouldn't cause any problems, unless we're referencing [NSApp mainWindow] in
> a prefpane somewhere.

I take it back. If the prefs window was an NSPanel, then ressing Command-V when it had focus but no first responder that handled |paste:| would trigger |paste:| on the main window (!), which would be confusing and irritating, to say the least.

-> 1.1
Target Milestone: Camino1.0 → Camino1.1
Assignee: mikepinkerton → nobody
Severity: enhancement → trivial
Target Milestone: Camino1.1 → Camino1.2
(Assignee)

Comment 7

11 years ago
Created attachment 232664 [details] [diff] [review]
Patch

This uses the same method we use to catch escape in the browser window.
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #232664 - Flags: review?(stuart.morgan)

Comment 8

11 years ago
Comment on attachment 232664 [details] [diff] [review]
Patch

r=me
Attachment #232664 - Flags: review?(stuart.morgan) → review+
(Assignee)

Updated

11 years ago
Attachment #232664 - Flags: superreview?(mikepinkerton)
Comment on attachment 232664 [details] [diff] [review]
Patch

sr=pink
Attachment #232664 - Flags: superreview?(mikepinkerton) → superreview+
landed trunk and branch
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.
Target Milestone: Camino1.2 → Camino1.1
You need to log in before you can comment on or make changes to this bug.