285531 - Pressing the Escape key does not close the preferences window

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Daniel Wilson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+

In a number of applications (iChat, Mail, iCal), pressing the Escape key closes
the preferences window.

Reproducible: Always

Steps to Reproduce:
1. Open Preferences window.
2. Press Escape.

Actual Results:  
Error beep.

Expected Results:  
Closed the Preferences window.

Comment 1

[Jasper]

I guess this is a valid enhancement request. Not a priority.

Comment 2

[Wevah (Nate Weaver)]

Not a priority, but an extremely easy fix: Simply change the class of the window
from NSWindow to NSPanel in the nib.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> Not a priority, but an extremely easy fix: Simply change the class of the
> window from NSWindow to NSPanel in the nib.

That won't have any adverse affects on other expected behavior/code, will it?  If not, this looks like some really simple polish we could add.

Comment 4

[Wevah (Nate Weaver)]

It shouldn't cause any problems, unless we're referencing [NSApp mainWindow] in a prefpane somewhere.

Comment 5

[Wevah (Nate Weaver)]

(In reply to comment #4)
> It shouldn't cause any problems, unless we're referencing [NSApp mainWindow] in
> a prefpane somewhere.

I take it back. If the prefs window was an NSPanel, then ressing Command-V when it had focus but no first responder that handled |paste:| would trigger |paste:| on the main window (!), which would be confusing and irritating, to say the least.

Comment 6

[Samuel Sidler (old account; do not CC)]

-> 1.1

Comment 7

[froodian (Ian Leue)]

Attachment: Patch

This uses the same method we use to catch escape in the browser window.

Comment 8

[Wevah (Nate Weaver)]

Comment on attachment 232664 [details] [diff] [review]
Patch

r=me

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 232664 [details] [diff] [review]
Patch

sr=pink

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed trunk and branch

Comment 11

[Samuel Sidler (old account; do not CC)]

Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.