Bugzilla displays inactive enum values

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Bugzilla-General
P1
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

2.19.2
Bugzilla 2.20
Bug Flags:
approval +
blocking2.20 +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Oh, I knew I might run into this. :-( I should have taken isactive out of the
enum stuff.

Ah, well. At the moment, Bugzilla displays values for enums even if isactive =
0. It shouldn't do that. You'll only see this on a brand-new install, where the
"---" values are inactive.
(Assignee)

Comment 1

13 years ago
I should do two things for this bug:

(1) Remove the default inactive field from the enum.
(2) Change get_legal_values to not return fields where isactive = 0.

I'd imagine that not enough people have been using the tip yet to where we'd
need to workaround this somehow.
(Assignee)

Updated

13 years ago
Flags: blocking2.20?
Priority: -- → P1
Whiteboard: FIX BEFORE 2.19.3
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Comment 2

13 years ago
Created attachment 179716 [details] [diff] [review]
Fix inactive fields

OK, I should have had this code be this way before I checked-in the enums
patch, but I guess I missed it.

Anyhow, I seem to recall that wicked reported this problem to me... so, you
want to review it? :-)
Attachment #179716 - Flags: review?(wicked)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Comment on attachment 179716 [details] [diff] [review]
Fix inactive fields

Erm.. I don't think I did. However, I did add a missing ORDER BY clause to that
SQL.. :) Anyway, your patch seems to work and does indeed remove disabled
values from interface.
Attachment #179716 - Flags: review?(wicked) → review+
(Assignee)

Updated

13 years ago
Flags: approval?
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
(Assignee)

Comment 4

13 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.389; previous revision: 1.388
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.319; previous revision: 1.318
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: FIX BEFORE 2.19.3
You need to log in before you can comment on or make changes to this bug.