285533 - Bugzilla displays inactive enum values

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Max Kanat-Alexander]

Oh, I knew I might run into this. :-( I should have taken isactive out of the
enum stuff.

Ah, well. At the moment, Bugzilla displays values for enums even if isactive =
0. It shouldn't do that. You'll only see this on a brand-new install, where the
"---" values are inactive.

Comment 1

[Max Kanat-Alexander]

I should do two things for this bug:

(1) Remove the default inactive field from the enum.
(2) Change get_legal_values to not return fields where isactive = 0.

I'd imagine that not enough people have been using the tip yet to where we'd
need to workaround this somehow.

Comment 2

[Max Kanat-Alexander]

Attachment: Fix inactive fields

OK, I should have had this code be this way before I checked-in the enums
patch, but I guess I missed it.

Anyhow, I seem to recall that wicked reported this problem to me... so, you
want to review it? :-)

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 179716 [details] [diff] [review]
Fix inactive fields

Erm.. I don't think I did. However, I did add a missing ORDER BY clause to that
SQL.. :) Anyway, your patch seems to work and does indeed remove disabled
values from interface.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.389; previous revision: 1.388
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.319; previous revision: 1.318
done