bugs.qa_contact should allow NULL

RESOLVED FIXED in Bugzilla 2.20

Status

()

defect
P1
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

2.19.2
Bugzilla 2.20
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
Right now, because of the way that MySQL treats NOT NULL, bugs.qa_contact is
already effectively 'default 0.' The logic to deal with qa_contact is too
difficult to always insert a 0 when we need to.

So, instead, we'll add a default to it. Very simple.
(Assignee)

Comment 1

14 years ago
Heck, we aren't frozen yet. Let's just fix this the right way. It SHOULD be
equally as simple, provided that nothing is currently depending on qa_contact
being 0.

justdave says to do it. :-)

By the way, this prevents post_bug from working on PostgreSQL, so it's important.
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: bugs.qa_contact should have a 'default 0' → bugs.qa_contact should allow NULL
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Updated

14 years ago
Blocks: 223706
(Assignee)

Comment 2

14 years ago
Attachment #176981 - Flags: review?(wurblzap)
(Assignee)

Updated

14 years ago
Attachment #176981 - Flags: review?(bugreport)
(Assignee)

Updated

14 years ago
Blocks: 285552
(Assignee)

Comment 3

14 years ago
Posted patch v2 (obsolete) — Splinter Review
I found another place where we'd inserted a 0 to initialqacontact; in
checksetup.
Attachment #176981 - Attachment is obsolete: true
Attachment #176984 - Flags: review?(bugreport)
(Assignee)

Updated

14 years ago
Attachment #176981 - Flags: review?(wurblzap)
Attachment #176981 - Flags: review?(bugreport)

Comment 4

14 years ago
Comment on attachment 176984 [details] [diff] [review]
v2

bitrotten
Attachment #176984 - Flags: review?(bugreport) → review-
(Assignee)

Comment 5

14 years ago
Posted patch v2.1Splinter Review
Fixed the bitrot.
Attachment #176984 - Attachment is obsolete: true
Attachment #177278 - Flags: review?(bugreport)

Updated

14 years ago
Attachment #177278 - Flags: review?(bugreport) → review+
(Assignee)

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 6

14 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.373; previous revision: 1.372
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.317; previous revision: 1.316
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.107; previous revision: 1.106
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.242; previous revision: 1.241
done
Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.88; previous revision: 1.87
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.68; previous revision: 1.67
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.47; previous revision: 1.46
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Blocks: 109474
You need to log in before you can comment on or make changes to this bug.