285713 - Cross-DB bz_column_info and bz_index_info

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P1)

Description

[Max Kanat-Alexander]

We need a function like bz_get_field_def, but one that works in a
cross-database-compatible way.

Comment 1

[Max Kanat-Alexander]

I'm also going to do index_info, because this turns out to be really easy.

Comment 2

[Max Kanat-Alexander]

Attachment: bz_column_info and bz_index_info

I also renamed one Schema function so that its purpose was clearer.

Comment 3

[Tomas Kopal]

Comment on attachment 177117 [details] [diff] [review]
bz_column_info and bz_index_info

> #--------------------------------------------------------------------------
>+sub get_column_abstract {
> 
>+=item C<get_column_abstract($table, $column)>
>+
>+ Description: A column definition from the abstract internal schema.
>+              cross-database format.
>+ Params:      $table - The name of the table
>+              $column - The name of the column that you want
>+ Returns:     A hash reference. For the format, see the docs for
>+              C<ABSTRACT_SCHEMA>.
>+              Returns undef if the column or table does not exist.
>+
>+=cut
>+
>+    my ($self, $table, $column) = @_;
>+

I didn't notice it before, but I don't like having the method description
*inside* of the function body. I prefer to have it *before* the function
header. But I suppose that should be different bug, as it is already in the
code in cvs.

Comment 4

[Max Kanat-Alexander]

Yeah, I agree about the POD location. But just like you, I said, "Well, it's
already done that way. Different bug."

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.36; previous revision: 1.35
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.11; previous revision: 1.10
done