Closed
Bug 285799
Opened 20 years ago
Closed 20 years ago
UserAgent string is malformed for XULRunner apps
Categories
(Toolkit Graveyard :: XULRunner, defect)
Toolkit Graveyard
XULRunner
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file)
11.05 KB,
patch
|
benjamin
:
first-review+
|
Details | Diff | Splinter Review |
UserAgent string is malformed for XULRunner apps.
Run simple.xulapp with HTTP logging enabled:
> user-agent = Mozilla/5.0 (X11; U; Linux i686; @AB_CD@; rv:1.8b2)
So, it looks like there is a problem with the locale setting, and we are also
missing the Gecko/ suffix. We should probably also incorporate the AppName into
the UA string.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Comment 1•20 years ago
|
||
OK, this patch fixes the UA string problem with the following changes:
1) define "general.useragent.vendor" and "general.useragent.vendorSub" in the
simple app's preferences file.
2) add "#filter substitution" to xulrunner.js so that
"general.useragent.locale" is correctly converted from @AB_CD@ to en-US.
3) recognize that Gecko/xyz is actually added after HTTP is initialized the
first time, so it isn't a bug ;-)
Other changes included in this patch:
- utilize XPI_NAME and restructure the build fu for simple
- include DTD file for simple to demonstrate locales.
Attachment #177199 -
Flags: first-review?(benjamin)
Assignee | ||
Comment 2•20 years ago
|
||
NOTE: the build changes included in this patch are probably only temporary.
ultimately, i want to move some of these steps into rules.mk, but i'm happy to
put that off until a later patch.
Updated•20 years ago
|
Attachment #177199 -
Flags: first-review?(benjamin) → first-review+
Assignee | ||
Comment 3•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•20 years ago
|
||
I just realized that I forgot to commit the xulrunner/app portions of this
patch. Those have now been committed.
Updated•18 years ago
|
Flags: in-testsuite?
Updated•9 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•