Closed Bug 285851 Opened 20 years ago Closed 20 years ago

Options dialog on OS/2 starts with wrong size

Categories

(Firefox :: Settings UI, defect)

x86
OS/2
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: bugs)

Details

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8b2) Gecko/20050311 Firefox/1.0+ The first time the options dialog on OS/2 starts, it is displayed with the size of the first panel. As this is much shorter than some of the other panels those other panels are cut off. In addition it has a wrong title.
Attached patch Use the same settings as Windows (obsolete) — Splinter Review
Just use the same window title as on windows. Similarly, an easy fix is to use the same size for the panel as on Windows. There might be a more intelligent solution to the size problem, however, as on Unix platforms it works without a fixed height.
Attachment #177220 - Flags: superreview?(bugs)
Attachment #177220 - Flags: review?(mkaply)
Shouldn't there be two new #endifs in here too?
Attached patch Better patchSplinter Review
Indeed, that was rubbish. This patch should work better, is easier to read and doesn't duplicate lines.
Attachment #177220 - Attachment is obsolete: true
Comment on attachment 177220 [details] [diff] [review] Use the same settings as Windows r=mkaply
Attachment #177220 - Flags: review?(mkaply) → review+
Attachment #177220 - Flags: superreview?(bugs)
Attachment #177220 - Flags: review+
Attachment #177223 - Flags: superreview+
Attachment #177223 - Flags: review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: