28598 - "\r" doesn't produce a line break!

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Raphael Ullmann]

Hi,
I've found out that "\r" doesn't produce a line break in a JS text as it is supposed to do.
NN 4.x and IE both do produce a line break.

Test case: http://www.datacomm.ch/ullmann/
When you move the mouse over one of the eight red buttons, the content of the textarea changes. In the textarea, there should be a line break after the capitalized title at the top of the area.

Comment 1

[Richard Zach]

DOM0.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Dosn't work on a Win98 mashine so I'm marking it crossplatform and confirming

I also think that this is a HTML-Forms problem rather then a DOM problem since
it seems that the \r actually gets into the textarea but it is displayed as a
unknown char rather then a newline.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Couldn't confirm and reassign to component owner at the same time :(

This was confirmed with build 2000-03-23-08 on Win98SE btw.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Testcase that sets the value of the textarea in onLoad. Should display two lines of text

Comment 5

[rods (gone)]

Buster, textarea issue

Comment 6

[buster]

akkana, you were working on newline issues in text controls, weren't you?

Comment 7

[Akkana Peck]

Currently, we're removing returns because it's an illegal character in the DOM.

I can make it so that any of \r, \r\n, or \n is turned into a single \n.

Cc'ing pollmann since he has a bug to add this sort of filtering to other form
elements, and we should coordinate and make sure we do the same thing
everywhere.  (Eric, should we have a utility routine like ConvertReturns that
all our
form elements can call, so we don't have to rewrite this code many times?)

Comment 8

[Eric Pollmann]

Sounds like a good plan to me.  A decent place to put this is in
nsFormControlHelper

Comment 9

[Akkana Peck]

Okay, nsFormControlHelper it is.  I've checked this in, and I'm typing this on
windows mozilla to test it.
This is a new line, for testing.
This is another new line.

Comment 10

[Akkana Peck]

*** Bug 29677 has been marked as a duplicate of this bug. ***

Comment 11

[Akkana Peck]

The fix I was testing when I made that last comment seemed to have made bugzilla
happier, but didn't solve the test case in this bug.  Turns out that
nsGfxTextControlFrame was doing its linebreak conversion at the wrong time (at
least for this case).  I've just checked in a fix which should fix this case as
well.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This works now for both my testcase and the original url. Nice work!

Verifying

Comment 13

[Raphael Ullmann]

Well done!
Line breaks seem to work correctly now.