286073 - internal code should use application/xml rather than text/xml

Status: RESOLVED INVALID

(Core :: XSLT, defect)

Description

[Anne (:annevk)]

For current usage, see:
 <http://lxr.mozilla.org/seamonkey/search?string=text%2Fxml>

Per RFC 3023 section 8.4 text/xml default to US-ASCII over HTTP when no
'charset' parameter is supplied. In order to avoid that we should switch our
internal code to use application/xml in which case the XML document can decide
about the character encoding.

If this is just switch and replace work, please say so and I'll provide a patch.
If not, if someone might be able to give guidelines or do the work himself that
would be great.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Should be just a search-n-replace. Though text/xml should still always work so
in some cases you should just add "application/xml".

Though you should make sure the content-policy implementors can deal.

Comment 2

[Anne (:annevk)]

Attachment: patch #1

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

So did you check that content-policy implementors can deal with this?

Comment 4

[Anne (:annevk)]

O sorry about that. I wanted to make a note that I wasn't sure what you meant by
that.

Comment 5

[Anne (:annevk)]

I did the check now. It seems to be ok. (I must admit Boris Zbarsky did explain
everything to me for which I am very grateful.)

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

You are changing the type passed to the NS_CheckContentLoadPolicy call. Are you
sure that won't break anything?

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ah, sorry, i should read all bugmail before replying :)

I'll review in a bit

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 177380 [details] [diff] [review]
patch #1

if bz says the contentpolicy change is ok then that's all I need :)

r=me

Comment 9

[Peter Van der Beken [:peterv]]

Comment on attachment 177380 [details] [diff] [review]
patch #1

>Index: extensions/transformiix/source/xslt/txOutputFormat.cpp
>===================================================================

>@@ -125,17 +125,17 @@ void txOutputFormat::setFromDefaults()
> 
>             if (mOmitXMLDeclaration == eNotSet)
>                 mOmitXMLDeclaration = eFalse;
> 
>             if (mIndent == eNotSet)
>                 mIndent = eFalse;
> 
>             if (mMediaType.IsEmpty())
>-                mMediaType.AppendLiteral("text/xml");
>+                mMediaType.AppendLiteral("application/xml");

Actually, the XSLT spec says the default is text/xml. See
http://www.w3.org/TR/xslt#output I think we should add a charset parameter with
the correct encoding (which should be stored in mEncoding).

Comment 10

[Anne (:annevk)]

Attachment: patch #2

s+sr=peterv, per discussion on IRC. peterv will update txOutputFormat.cpp if
needed.

I contacted the WG about the specification:
 <http://lists.w3.org/Archives/Public/xsl-editors/2005JanMar/0045.html>

Comment 11

[Anne (:annevk)]

Attachment: patch #3

Take into account some additional comment made on IRC by timeless. (Again with
approval from peterv.)

Comment 12

[Anne (:annevk)]

peterv said he would address comment 9 if needed.

Comment 13

[Anne (:annevk)]

I no longer think this is worth doing. text/xml is fine.