286096 - Review xpfe component usage in Camino

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P2)

Description

[Simon Fraser [no longer active]]

We have a number of bugs in Camino because we load xpfe components by mistake
(bug 285554, bug 280342).

I think we should figure out which of these components we really need, and make
sure only those are registered. This may involve #ifdeffing
xpfe/build/nsModule.cpp, or making our own.

Comment 1

[Simon Fraser [no longer active]]

Attachment: xpfe build patch

Here's the patch in all its vomitous glory. #ifdeffing galore!

Comment 2

[Benjamin Smedberg]

Comment on attachment 178208 [details] [diff] [review]
xpfe build patch

Holy smokes, we need to really solve this xpfe/components problem sometime. But
yes, this is the right solution in the short term.

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 178208 [details] [diff] [review]
xpfe build patch

This patch doesn't work. You can't write preprocessor expressions like 

#if (MOZ_BUILD_APP != macbrowser)

so we need to define MACBROWSER somewhere, as I originally suggested.

Comment 4

[Simon Fraser [no longer active]]

Attachment: Revised patch

Comment 5

[timeless]

Comment on attachment 178310 [details] [diff] [review]
Revised patch

you need to carry r=bsmedberg for the build bits ;-)

Comment 6

[Benjamin Smedberg]

Comment on attachment 178310 [details] [diff] [review]
Revised patch

Ick, that sucks. Oh well, I'll go back to the MOZ_BUILD_APP drawing boards some
other time.

Comment 7

[Simon Fraser [no longer active]]

Checked in. Thanks all. This also resolves bug 285554 and bug 280342.