Closed Bug 286133 Opened 20 years ago Closed 20 years ago

In View Cookies, the sites should be sorted alphabetically by default

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ryukbk, Assigned: mconnor)

References

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050314 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050314 Firefox/1.0+ When you open View Cookies, sites are placed randomly (or in the order in cookies.txt probably) now. Cookies should be sorted by 'Site' on load. Reproducible: Always Steps to Reproduce:
Version: unspecified → Trunk
This is now WFM after the new options window landing from bug 274712.
(In reply to comment #1) > This is now WFM after the new options window landing from bug 274712. Still not working on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520 Firefox/1.0+
Depends on: 274712
Summary: Cookies should be sorted by 'Site' in Cookies Viewer → Cookies should be sorted by 'Site' in Cookies Viewer in default
Cookies are now grouped by site in the new Cookie Viewer. But the sites are not sorted alphabetically by default, as they should. The call to sort them is commented out: http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/cookies.js#61
OS: Windows XP → All
Hardware: PC → All
Summary: Cookies should be sorted by 'Site' in Cookies Viewer in default → Cookie sites should be sorted alphabetically Cookies Viewer by default
Flags: blocking-aviary1.1?
Assignee: bugs → mconnor
Flags: blocking-aviary1.1? → blocking1.8b4+
Summary: Cookie sites should be sorted alphabetically Cookies Viewer by default → In View Cookies, the sites should be sorted alphabetically by default
The problem I've seen when testing the sort is that performance gets REAL bad when you go to the bottom of the list and start clicking up, and obviously the same concept applies to other areas. I'll see if any optimization could be done on it.
(In reply to comment #3) > The call to sort them is commented out: > http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/cookies.js#61 This was uncommented in bug 285002's checkin, which should also have fixed some of the slowness. Can anybody verify?
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/cookies.js#173 That seems to be the only thing left for this bug. I have tested by putting sort in there, but it's not consistent with its results (i.e. you can delete a cookie from a site, visit that site and the entry for that site appears twice), plus it gives the rendering of pages a hit if a cookie's being added on that page. I say we don't implement sorting in this case. mconnor, your take on this?
Also, there is still a problem. When clearing a filter, the list becomes unsorted.
please file a followup on the other issues.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.