286182 - When instant-apply is on, textfield-widget prefs values aren't being saved during input

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P2)

Description

[Josh Aas]

It is not possible to change the homepage. Typing a new site into the prefs box
for homepage does nothing and is simply reset to the previous home page (in this
case Firefox central).

Comment 1

[Josh Aas]

You can actually change the home page, but it isn't remembered unless you hit
enter. This is not standard behavior and isn't obvious anyway.

Comment 2

[Asaf Romano (gone)]

wfm - whenever i (just) change the homepage textbox content, Go->Home in a
brower window works as expected (tested in 20050312).

Comment 3

[José Jeria]

Does not work for me using 20050316 trunk build, mac os x.

I have currently have about:blank as my homepage. Changing it does nothing
(clicked on the home icon). Also tried to switch tabs in the options after
enteringt the new location to see if it was saved with no luck.

Workaround in comment 1 helped to change it though.

Comment 4

[Asaf Romano (gone)]

could you please find out the regression timeframe?

Comment 5

[José Jeria]

I am not sure this ever worked with the new options.

Comment 6

[Asaf Romano (gone)]

20050316 - still wfm (using go->home).

Comment 7

[Asaf Romano (gone)]

and the home button as well. Steps to repro'?

Comment 8

[Asaf Romano (gone)]

hm:
1. Open prefs.
2. change the home page address.
3. move to a brower window (without closing the pref window)

->WFM

But i do see the bug if i close the pref window in after [2].

Comment 9

[Tom DeLozier]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050528
Firefox/1.0+

does not work for me
open preferences->type new url for home->close window with red "x" and pref is
not saved.

Works for me
visit wanted home page in web browser->open preferences->select "use current
pages"->close window with red "x" and pref is saved.

Works for me
open preferences->type new url for home->hit "return" button on keyboard,
preferences window is closed by itself and preference is saved.

Works for me
open preferences->type new url for home->change focus to browser window->change
focus back to preference window->close window with red "x" and pref is saved.

Comment 10

[Josh Aas]

Mano dealt with this kind of thing recently, over to him

Comment 11

[Asaf Romano (gone)]

Attachment: patch

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 187786 [details] [diff] [review]
patch

a=mkaply

Comment 13

[Asaf Romano (gone)]

Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.21; previous revision: 1.20
done