286197 - preferences should not close upon hitting enter on Mac OS X

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P2)

Description

[Josh Aas]

1) Open preferences
2) type in a new home page URL and hit enter

Preferences close upon hitting enter in step #2. This is not standard behavior
on Mac OS X and shouldn't happen.

Comment 1

[Asaf Romano (gone)]

Attachment: patch v1 - disable hidden buttons

(not like hidden, the disabled property/attribute doesn't affect hbox's
children.)

Comment 2

[Asaf Romano (gone)]

Comment on attachment 177736 [details] [diff] [review]
patch v1 - disable hidden buttons

hm, this breaks the window close button.

Comment 3

[Asaf Romano (gone)]

Attachment: v2

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 177841 [details] [diff] [review]
v2

Let's do this by not specifying a default button on Mac (really, specifying
none).	Depends on some other, necessary stuff.

Comment 5

[Asaf Romano (gone)]

-> Toolkit/prefs

Comment 6

[Asaf Romano (gone)]

Attachment: the preferences part

Of course, it needs the patch from the dialog.xml bug.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 178656 [details] [diff] [review]
the preferences part

The second default button patch well handles this case.

Comment 8

[Asaf Romano (gone)]

err, toolkit/prefs again.

Comment 9

[Asaf Romano (gone)]

Attachment: back to plan a

simply disable the accept button

Comment 10

[Asaf Romano (gone)]

Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.24; previous revision: 1.23
done