286225 - All keyboard functionality ceases to work when a DOM object disappears

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Timwi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1 StumbleUpon/1.9992
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1 StumbleUpon/1.9992

Please see the attached test case.

Reproducible: Always

Steps to Reproduce:
1. Bring up the test case while having JavaScript enabled.
2. Click the link that says "Click me!". (Typing part of the link text and
   pressing ENTER also works.) The link disappears.
3. Then try to do absolutely anything keyboardy, e.g. Ctrl+L, Ctrl+F,
   Ctrl+Tab, Ctrl+W, Alt+F. None of them do anything. You're stuck!

Comment 1

[Timwi]

Attachment: Test case

This is the test case. See steps to reproduce.

Comment 2

[Aaron Leventhal]

We should look for situations where the current focus is in a subtree that
becomes hidden, destroyed or disabled, and move focus somewhere legal.

Not sure what to do in the evil case where everything in the current window
becomes unfocusable, but that signifies a larger problem with the app than just
for the keyboard.

Comment 3

[Ng Ming Hong]

WFM: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223
Firefox/1.0.1

Comment 4

[David Stone]

Couldn't we just set focus to the parent of the element that's about to be
destroyed. If the element getting destroyed is a document, then we could just
give focus to the app itself, right? 

Comment 5

[Aaron Leventhal]

(In reply to comment #4)
> Couldn't we just set focus to the parent of the element that's about to be
> destroyed. If the element getting destroyed is a document, then we could just
> give focus to the app itself, right? 

Only some elements are focusable. For example, a <div> is not generally
focusable. The code can call nsIFrame::IsFocusable() to find something
focusable. In the case of HTML, we could focus the document when the currently
focused element is no longer focusable.

Comment 6

[Hermann Schwab]

bug seen Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050402
Firefox/1.0+

wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050329

Comment 7

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 8

[Aaron Leventhal]

WORKSFORME. Maybe it was fixed by bug 307172?

Comment 9

[Timwi]

Looks like it. Thanks.

Comment 10

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381