286298 - Remove the PKCS11_STATIC_ATTRIBUTES macro

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

Bob Relyea said that we can remove the PKCS11_STATIC_ATTRIBUTES
macro from the softoken code.  This macro is always defined.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Removed PKCS11_STATIC_ATTRIBUTES and the related
macro PKCS11_REF_COUNT_ATTRIBUTES.

PKCS11_STATIC_ATTRIBUTES is always defined.
PKCS11_REF_COUNT_ATTRIBUTES is never defined.

Some comments need to be updated with the removal
of these two macros.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Can we also get rid of PK11_USE_THREADS, and always unconditionally do the
code now wrapped in that macro?

Comment 3

[Wan-Teh Chang]

I checked in the patch on the NSS trunk for NSS 3.10.

Checking in pkcs11i.h;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11i.h,v  <--  pkcs11i.h
new revision: 1.33; previous revision: 1.32
done
Checking in pkcs11u.c;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11u.c,v  <--  pkcs11u.c
new revision: 1.61; previous revision: 1.60
done

I will remove PK11_USE_THREADS in another bug.

Comment 4

[Robert Relyea]

I think so, unless we have some platform that we can't be threadsafe on...

bob

Comment 5

[Robert Relyea]

Comment on attachment 177541 [details] [diff] [review]
Proposed patch

r+ relyea, boy, that really simplifies reading the code now;)