Closed
Bug 286298
Opened 20 years ago
Closed 20 years ago
Remove the PKCS11_STATIC_ATTRIBUTES macro
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.10
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
12.00 KB,
patch
|
julien.pierre
:
review+
rrelyea
:
superreview+
|
Details | Diff | Splinter Review |
Bob Relyea said that we can remove the PKCS11_STATIC_ATTRIBUTES
macro from the softoken code. This macro is always defined.
Assignee | ||
Comment 1•20 years ago
|
||
Removed PKCS11_STATIC_ATTRIBUTES and the related
macro PKCS11_REF_COUNT_ATTRIBUTES.
PKCS11_STATIC_ATTRIBUTES is always defined.
PKCS11_REF_COUNT_ATTRIBUTES is never defined.
Some comments need to be updated with the removal
of these two macros.
Attachment #177541 -
Flags: superreview?(rrelyea)
Attachment #177541 -
Flags: review?(julien.pierre.bugs)
Updated•20 years ago
|
Attachment #177541 -
Flags: review?(julien.pierre.bugs) → review+
Comment 2•20 years ago
|
||
Can we also get rid of PK11_USE_THREADS, and always unconditionally do the
code now wrapped in that macro?
Assignee | ||
Comment 3•20 years ago
|
||
I checked in the patch on the NSS trunk for NSS 3.10.
Checking in pkcs11i.h;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11i.h,v <-- pkcs11i.h
new revision: 1.33; previous revision: 1.32
done
Checking in pkcs11u.c;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11u.c,v <-- pkcs11u.c
new revision: 1.61; previous revision: 1.60
done
I will remove PK11_USE_THREADS in another bug.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Comment 4•20 years ago
|
||
I think so, unless we have some platform that we can't be threadsafe on...
bob
Comment 5•20 years ago
|
||
Comment on attachment 177541 [details] [diff] [review]
Proposed patch
r+ relyea, boy, that really simplifies reading the code now;)
Attachment #177541 -
Flags: superreview?(rrelyea) → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•