286342 - Footer has a lot of empty space for non-admin users

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Jason Remillard]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: 

The bugzilla footer is poorly formatted for users that are not admins (99% of
bugzilla users). The top row is full of usefull links. The second row says Edit
Prefs, then nothing, the third row says has the saved searches, whick for 99% of
the people will just contain my bugs. 80% of the footer is blank in order to
leave space for the admin options. This is backwards.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Bill Barry]

Perhaps prefs should be in the first row and the second row should not be shown for unprivleged users and renamed to Manage (and the first row renamed common).

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> Perhaps prefs should be in the first row and the second row should not be shown
> for unprivleged users and renamed to Manage (and the first row renamed common).
> 

I agree! Are you interested in attaching a patch?

Comment 3

[Bill Barry]

Attachment: Renames Edit to Manage and puts prefs in first line

Here is a patch; it renames the edit menu to manage, and it puts the prefs link next to the logout link in the previous line.

Comment 4

[Bill Barry]

Attachment: this also renames Action to Common

I don't know if it should obsolete the first one or not; take your pick.

Comment 5

[Bill Barry]

Attachment: action->common, edit->manage, prefs->first line

missed some quote chars

Comment 6

[Bill Barry]

Attachment: edit->manage, prefs->first line

Fixed it in the first version too; I think I am done for now.

Comment 7

[victory <[e-mail]>]

Comment on attachment 230500 [details] [diff] [review]
action->common, edit->manage, prefs->first line

   [% IF user.login %]
+    | <a href="userprefs.cgi">Prefs</a>
+  [% END %]
+
+  [% IF user.login %]

these TT directives aren't needed i think

Comment 8

[Frédéric Buclin]

The admin links are no longer in the page footer, see bug 286338.