Closed Bug 286422 Opened 19 years ago Closed 18 years ago

Preparing linux tinderboxes for svg

Categories

(Webtools Graveyard :: Tinderbox, defect)

Product:
Webtools Graveyard
Component:
Tinderbox
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tor, Unassigned)

References

Details

Attachments

(4 files, 2 obsolete files)

condition FT_LOAD_TARGET_{NORMAL,LIGHT} usage
1.19 KB, patch
Details | Diff | Splinter Review
handle old Xrender (working)
7.38 KB, patch
Details | Diff | Splinter Review
define FT_LOAD_TARGET_{NORMAL|LIGHT} if needed
1.19 KB, patch
Details | Diff | Splinter Review
tweak Xrender approach - have cairo include the right header
137.41 KB, patch
Details | Diff | Splinter Review 
The linux tinderboxes maintained by mozilla.org will need some help
to build svg.  I think that installing a newer pkgconfig someplace
that can be included in the path might be enough.  Tried to install
rh7.1 here to experiment, but the machine was too new for that distrib.

Build instructions were updated and the changes announced to the
build and unix newsgroups on 2005-03-07.  No feedback.
pkg-config:
  http://pkgconfig.freedesktop.org/wiki/
  http://pkgconfig.freedesktop.org/releases/

I installed pkg-config 0.16.0 on otaku.  Then it complained that freetype2 was
needed.

I switched otaku, monkeypox, and bismark from --enable-svg-renderer-libart
(which no longer works) to --enable-svg-renderer=libart so that they go green.

I tried installing pkgconfig 0.16.0 on balsa (Red Hat 7.1), which has freetype2.
 The configure script there also complained that freetype2 was needed but not
present.  (It just occurred to me it could be a config.cache problem, since it
might be reusing an ft2 test done elsewhere.  I'll try that tommorow, perhaps.)
Er, what it calls use_freetype depends on a test for fontconfig, which Red Hat
7.x systems don't have.
So, I'm thinking we just shouldn't bother getting SVG to build on Linux
tinderboxes that are pre-Red Hat 8.0.  The builds we ship should be compiled on
Red Hat 8.0 and not binary-compatible with anything before it.
On Red Hat 8:

/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_ft_font.c:
In function `_get_load_flags':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_ft_font.c:528:
error: `FT_LOAD_TARGET_LIGHT' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_ft_font.c:528:
error: (Each undeclared identifier is reported only once
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_ft_font.c:528:
error: for each function it appears in.)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_ft_font.c:531:
error: `FT_LOAD_TARGET_NORMAL' undeclared (first use in this function)

Doesn't seem critical - might loose a little visual quality in some
circumstances.
Blocks: 122092
With a variant of that (defining them instead of commenting them out), I get:

/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
In function `_cairo_xlib_surface_set_matrix':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:457:
error: `XTransform' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:457:
error: (Each undeclared identifier is reported only once
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:457:
error: for each function it appears in.)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:457:
error: parse error before "xtransform"
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:462:
error: `xtransform' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:476:
error: syntax error before "identity"
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:482:
error: `identity' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
At top level:
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:488:
error: parse error before '->' token
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:488:
warning: type defaults to `int' in declaration of `XRenderSetPictureTransform'
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:488:
warning: function declaration isn't a prototype
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:488:
warning: data definition has no type or storage class
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
In function `_cairo_xlib_surface_set_filter':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:512:
error: `FilterFast' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:515:
error: `FilterGood' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:518:
error: `FilterBest' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:521:
error: `FilterNearest' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:524:
error: `FilterBilinear' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:531:
warning: implicit declaration of function `XRenderSetPictureFilter'
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
In function `_cairo_xlib_surface_composite_trapezoids':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:766:
warning: implicit declaration of function `XRenderCompositeTrapezoids'
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:769:
warning: implicit declaration of function `XRenderFindStandardFormat'
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:769:
error: `PictStandardA8' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:772:
error: `XTrapezoid' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:772:
error: parse error before ')' token
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:772:
warning: left-hand operand of comma expression has no effect
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:772:
error: parse error before ')' token
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
In function `_cairo_xlib_surface_create_with_size':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:924:
error: `PictStandardA1' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:927:
error: `PictStandardA8' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:930:
error: `PictStandardRGB24' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:934:
error: `PictStandardARGB32' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:943:
warning: pointer/integer type mismatch in conditional expression
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:
In function `_get_glyphset_cache':
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:1165:
error: `PictStandardA8' undeclared (first use in this function)
/builds/tinderbox/Firefox/Linux_2.4.20-28.8_Depend/mozilla/gfx/cairo/cairo/src/cairo_xlib_surface.c:1165:
warning: assignment makes pointer from integer without a cast
Attached patch handle old Xrender (obsolete) — — Splinter Review 
This should allow building against old versions of Xrender, but the result
won't show anything as it seems that the xlib fallback code has bitrotted.

        Attachment #180526 -
        Attachment is obsolete: true

    
    

    
  
Another option: include libXrender in the moz tree and build it if autoconfig
finds Xrender with minor < 6.


    
    

    
  
Add a "typedef int XFixed;" right before the definition of _XTransform
in cairo-xlib.h.


    
    

    
  


  

    
  

        Attachment #180641 -
        Attachment is obsolete: true

    
    

    
  
If you try the Xrender patch, note that patch doesn't seem to want to generate
the zero length gfx/cairo/Xrender/config.h file from the diff.


    
    

    
  
FWIW, RH9 compiles a current mozilla tree with svg+cairo without needing any
patches or package updates.


    
  
Flags: blocking1.8b2+

    
    

    
  
we're there. pulling this off the blocking radar.
Flags: blocking1.8b2+

    
    

    
  
Has this bug been fixed?  We are looking to close bug 122092.  No comments have been posted since 05/16/2005.

    
    

    
  
Apparently, the relevant Firefox tinderboxen should have been fixed. OTOH, lhasa, which builds gtk2 SeaMonkey builds, doesn't build cairo yet, so it might not have the needed changes. We also have been talking about that in bug 294182.

    
  
Blocks: 294182

    
    

    
  
Mass reassign of open bugs for chase@mozilla.org to build@mozilla-org.bugs.
Assignee: chase → build

    
    

    
  
I think this is fixed; I know SVG is turned on in the 1.5.0.x tinderboxen, and it seems to be working.

Please reopen if I'm wrong.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Component: Tinderbox Configuration → Tinderbox
Product: mozilla.org → Webtools
Product: Webtools → Webtools Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: