Closed Bug 286669 Opened 15 years ago Closed 15 years ago

Add dependency on Storable

Categories

(Bugzilla :: Installation & Upgrading, defect, P1)

2.19.2
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Perl 5.8 ships with Storable, but version 5.6 does not. So we need to add a
check for its existence in checksetup. We don't care what version we get, as
long as it's installed.
Status: NEW → ASSIGNED
Flags: blocking2.20?
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Attached patch Require StorableSplinter Review
I love editing this part of checksetup. It's so easy. :-)
Attachment #177817 - Flags: review?(wicked)
Flags: blocking2.20? → blocking2.20+
Comment on attachment 177817 [details] [diff] [review]
Require Storable

>Index: checksetup.pl
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v
..
> my %ppm_modules = (
>@@ -338,6 +342,7 @@
..
>+    'Storable'          => 'Storable',

Nit: This is not necessary because ppm sub uses the module name as is if no
mapping is provided.

Otherwise, looks and works fine to me. Good to go, assuming you are sure we
need this dependency. :)
Attachment #177817 - Flags: review?(wicked) → review+
OK, I'll remove the useless part on checkin.
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.375; previous revision: 1.374
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.