286689 - Cross-DB bz_add_index and bz_drop_index

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P1)

Description

[Max Kanat-Alexander]

We don't need a bz_rename_index. I'm fairly sure that these are the last two
Bugzilla::DB functions that need to be created.

Comment 1

[Max Kanat-Alexander]

Attachment: add_index and drop_index

OK, here we go. After this one comes the REAL heavy lifting (actual checksetup
modifications).

Comment 2

[Tomas Kopal]

Comment on attachment 177842 [details] [diff] [review]
add_index and drop_index

>+        print "Adding new index $name to table $table ...\n";
>+        print "Removing index '$name' from the $table table...\n";
>+    die "Attempted to delete nonexistent index $name on the $table table" 

Nit: make the messages a bit more consistent :-).


>   $dbh->bz_add_column($table, $name, \%definition);
>+  $dbh->bz_add_index($table, $name, $definition);

Why has the definition different type here? It's used in the same way, isn't
it?

Otherwise, looks good.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> >   $dbh->bz_add_column($table, $name, \%definition);
> >+  $dbh->bz_add_index($table, $name, $definition);
> 
> Why has the definition different type here? It's used in the same way, isn't
> it?

  Actually, no. Index definitions can be either arrayrefs or hashrefs. Some day
I will re-arch that, but not now. :-)

Comment 4

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.41; previous revision: 1.40
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.14; previous revision: 1.13
done
Checking in Bugzilla/DB/Schema/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema/Mysql.pm,v  <--  Mysql.pm
new revision: 1.4; previous revision: 1.3
done