286718 - mailnews spell check - [Enter] no longer chooses 'replace' although 'replace' is 'active' button.

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Bishop Clark (LC957)]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050317
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050317

(Sorry for the bad Component:  none of the mailnews onew were appropriate!)

When editing a new message, I've grown into the habit, with mozilla spellcheck,
of being able to type in my word correction and hitting [Enter] to have it
accepted (similar to finding the mouse, moving over to the [replace] button and
hitting it).  

1.8b2 doesn't seem to accept my repeated banging on the [enter] key as
equivalent to clicking [replace].  1.7.5 does exactly as I expect, however.

Reproducible: Always

Steps to Reproduce:
1. compose new email, text mode, with some words spelled badly
2. open Spell check
3. ignore the suggestions:  retype the first correction and hit [enter]

Actual Results:  
correction entry had correct spelling, but the word wasn't changed;  had to
click [replace] to perform the replacement

Expected Results:  
it should have performed the replacement and moved to the next word: since
[replace] was the only un-dimmed box, hitting [enter] should have done the same
as if I were to have clicked it.

Comment 1

[[e-mail]]

Attachment: Fix last caller of Replace()

Comment 2

[[e-mail]]

FYI this was a regression from bug 233275.

Comment 3

[Scott MacGregor]

Comment on attachment 177868 [details] [diff] [review]
Fix last caller of Replace()

FYI, I checked this change into Thunderbird as well.

Comment 4

[Wayne Mery (:wsmwk)]

fails for me 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102203 SeaMonkey/2.0a1pre

Comment 5

[Wayne Mery (:wsmwk)]

fails also SeaMonkey 1.1.4
works thunderbird v2

Comment 6

[[e-mail]]

Comment on attachment 177868 [details] [diff] [review]
Fix last caller of Replace()

Trying different reviewer. (Also need a= for branch!)

Comment 7

[Ian Neal]

Comment on attachment 177868 [details] [diff] [review]
Fix last caller of Replace()

r=me
a-SM1.1.7=me though I suspect that is not sufficient.

Comment 8

[[e-mail]]

Fix checked in.