286926 - && should be & in nsMsgDBView::ToggleExpansion

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Jesse Ruderman]

http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMsgDBView.cpp#3923

if (!(flags & MSG_VIEW_FLAG_ISTHREAD) || !(flags && MSG_VIEW_FLAG_HASCHILDREN))

&& looks like a typo for &.

Comment 1

[Art Haas]

Attachment: Patch changing '&&' to '&'

There are two occurances of the '&&' which look like they should be '&'. The
attached patched changes both.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Art: you need to request review/super-review.  Please see
http://www.mozilla.org/hacking/life-cycle.html for details, and
http://www.mozilla.org/owners.html for the list of people.

Comment 3

[Jean-Francois Ducarroz]

Comment on attachment 178041 [details] [diff] [review]
Patch changing '&&' to '&'

R=ducarroz. Thank you for fixing it

Comment 4

[(not reading, please use [e-mail] instead)]

re-assign to bienvenu.

david, can you land this?

Comment 5

[David :Bienvenu]

fix checked in, thx, Art. I also cleaned up some of the braces style in that
code as well...

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR for code inspection.