287105 - Reload button is disabled after adding it back to toolbar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[u88484]

Steps to reproduce:
1) Right click on toolbar->customize
2) drag and drop the reload icon into the customize box
3) drag and drop the reload icon back to the toolbar
4) Click done in the customize box and now the reload button is disabled for all
tabs that are opened until a new tab is opened. Also sometimes if two tabs are
opened the back and forward buttons are disabled on the tabs not in focus. This
happens with small icons no text.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320
Firefox/1.0+

I suspect one of these bugs caused this regression.
237776
284130
or bug about reload icon disabled on random pages (sorry can't find bug #)

Comment 1

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050321
Firefox/1.0+
WFM. I follow the repo instructions and afterwards I can still click the reload
button fine in my tabs.

Comment 2

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050321
Firefox/1.0+
Plse ignore comment 1 - I was wrong. Following the steps the reload button is
indeed greyed out afterwards. (Note to self: the Stop button is not the Refresh
button)

Comment 3

[Peter van der Woude [:Peter6]]

the word is, this regressed after bug 237776 was checked in.

Comment 4

[Peter van der Woude [:Peter6]]

CC->Ryan VanderMeulen

Comment 5

[Mike Connor [:mconnor]]

Good catch:
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#2776 is
where the fix needs to go to check/enable this as needed.

Comment 6

[darryllbagg]

In my case, I was simply closing a tab - nothing special - when I got the
following: The instruction at "0x6009aa15" referenced memory at "0x6003d0e0". 
The memory could not be "read".
And I was forced to kill Firefox completely.

Comment 7

[Asaf Romano (gone)]

See bug 309953... going to wallpaper this.

Comment 8

[Asaf Romano (gone)]

Attachment: patch

Comment 9

[Asaf Romano (gone)]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.514; previous revision: 1.513
done

Comment 10

[Mike Schroepfer]

Comment on attachment 197323 [details] [diff] [review]
patch

Approved per 9/26 bug triage meeting.

Comment 11

[Asaf Romano (gone)]

1.8 branch:
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.32; previous revision: 1.479.2.31
done