Closed Bug 287105 Opened 15 years ago Closed 15 years ago

Reload button is disabled after adding it back to toolbar

Categories

(Firefox :: Toolbars and Customization, defect, P1, major)

defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: u88484, Assigned: mano)

References

(Depends on 1 open bug)

Details

(Keywords: fixed1.8, regression)

Attachments

(1 file)

Steps to reproduce:
1) Right click on toolbar->customize
2) drag and drop the reload icon into the customize box
3) drag and drop the reload icon back to the toolbar
4) Click done in the customize box and now the reload button is disabled for all
tabs that are opened until a new tab is opened. Also sometimes if two tabs are
opened the back and forward buttons are disabled on the tabs not in focus. This
happens with small icons no text.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320
Firefox/1.0+

I suspect one of these bugs caused this regression.
237776
284130
or bug about reload icon disabled on random pages (sorry can't find bug #)
Keywords: regression
Summary: Reload disabled on all tabs after removing and adding back to toolbar → Reload icon disabled on all tabs after removing and adding back to toolbar
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050321
Firefox/1.0+
WFM. I follow the repo instructions and afterwards I can still click the reload
button fine in my tabs.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050321
Firefox/1.0+
Plse ignore comment 1 - I was wrong. Following the steps the reload button is
indeed greyed out afterwards. (Note to self: the Stop button is not the Refresh
button)
the word is, this regressed after bug 237776 was checked in.
CC->Ryan VanderMeulen
Good catch:
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#2776 is
where the fix needs to go to check/enable this as needed.
Assignee: bugs → ryanvm
Blocks: 237776
No longer depends on: 237776
In my case, I was simply closing a tab - nothing special - when I got the
following: The instruction at "0x6009aa15" referenced memory at "0x6003d0e0". 
The memory could not be "read".
And I was forced to kill Firefox completely.
Assignee: ryanvm → nobody
QA Contact: bugzilla → toolbars
Flags: blocking1.9a1?
Flags: blocking-aviary2.0?
Flags: blocking1.8b5? → blocking1.8b5+
Assignee: nobody → mconnor
Flags: blocking1.9a1?
Flags: blocking-aviary2.0?
Flags: blocking1.8b5+ → blocking1.8b5-
See bug 309953... going to wallpaper this.
Assignee: mconnor → bugs.mano
Severity: normal → major
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Reload icon disabled on all tabs after removing and adding back to toolbar → Reload button is disabled after adding it back to toolbar
Target Milestone: --- → Firefox1.5
Attachment #197323 - Flags: review?(mconnor) → review+
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.514; previous revision: 1.513
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: blocking1.8b5- → blocking1.8b5?
Comment on attachment 197323 [details] [diff] [review]
patch

Approved per 9/26 bug triage meeting.
Attachment #197323 - Flags: approval1.8b5? → approval1.8b5+
Flags: blocking1.8b5? → blocking1.8b5+
1.8 branch:
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.32; previous revision: 1.479.2.31
done
Keywords: fixed1.8
Depends on: 309953
You need to log in before you can comment on or make changes to this bug.