287213 - JavaScript strict warnings in nsHelperAppDlg.js

Status: VERIFIED WONTFIX

(Firefox :: File Handling, defect)

Description

[arjenwarendorff+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

Found "redeclaration of var ..." 3 times in file: "Mozilla
Firefox/components/nsHelperAppDlg.js"
Warning: "redeclaration of var x"
Details:

1)
var: prefs
warning on line: 178
already declared on line: 91

2)
var: openHandler
warning on line: 546
already declared on line: 524 (Warning: only when if() evaluated to true on line
519)

3)
var: useDefault
warning on line: 563
already declared on line: 545


Reproducible: Always

Actual Results:  
Strict JavaScript warning in the JavaScript Console

Expected Results:  
Don't show any warnings

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

useragent looks like this is for the firefox version of the file

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Redeclarations are no longer strict warnings, removing them reduces code clarity.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

v