287244 - DOCTYPE should not imply a default namespace

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Anne (:annevk)]

For at least one DOCTYPE SVG implies a default namespace for the document, which
is incorrect, since even if that DTD defined some default namespace, we are not
a validating parser.

jwatt pointed out that the only place in the source code where that DOCTYPE is
specified is here:
<http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/src/nsExpatDriver.cpp#229>

Comment 1

[Anne (:annevk)]

Attachment: testcase

Comment 2

[Anne (:annevk)]

I did some digging and found:
 <https://bugzilla.mozilla.org/show_bug.cgi?id=145810#c3>
 <https://bugzilla.mozilla.org/show_bug.cgi?id=113400>

I suggest that we remove that DOCTYPE and svg.dtd:
 <http://lxr.mozilla.org/seamonkey/source/layout/svg/base/src/svg.dtd>

Comment 3

[Anne (:annevk)]

Attachment: patch

This would fix the bug. I think svg.dtd can be removed as well after this
change.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Bradley, does this patch seem reasonable to you?

Comment 5

[Anne (:annevk)]

If the file removed, this should change too:
 <http://lxr.mozilla.org/seamonkey/source/layout/svg/base/src/Makefile.in#110>

Comment 6

[Bradley Baetz (:bbaetz)]

Does the SVG testsuite wor with this? The initial SVG spec required that we
magically imply the xmlns, but since we're not a validating parser, we didn't.
That did get changed, but I'm not sure whast out there wihtout the appropriate
namespace on the <svg>.

Comment 7

[Robin Berjon]

(In reply to comment #6)
> Does the SVG testsuite wor with this? The initial SVG spec required that we
> magically imply the xmlns, but since we're not a validating parser, we didn't.
> That did get changed, but I'm not sure whast out there wihtout the appropriate
> namespace on the <svg>.

An old version of the DTD, published in an ancient draft, defaulted the xmlns. The spec didn't require 
that it be magically defaulted, that only worked in (at least partially) validating parsers. For purposes of 
SVG processing I would recommend to completely ignore the DOCTYPE (except the internal subset of 
course). There will be no DOCTYPE for 1.2, it is completely deprecated.

Comment 8

[Anne (:annevk)]

Note also that we only do this for an ancient DTD that should not be used anyway.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 178789 [details] [diff] [review]
patch

sr=bzbarsky, though if that makes svg.dtd unused I'd like to see a followup
patch removing references to it and removing the file....

Comment 10

[Anne (:annevk)]

Attachment: that followup patch?

So who needs to review this?

Comment 11

[Anne (:annevk)]

Both patches have been checked in by timeless. Marking FIXED.