287296 - bz_get_index_def doesn't work for multi-column index

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Joel Peshkin]

bz_get_index_def checks for a field included in an index by looking at the
column 4 of "SHOW INDEX FROM $table"

Column 4 is the name of A FIELD from that table.  It should use column 2 which
is the name of the key.

Comment 1

[Max Kanat-Alexander]

WAIT!

checksetup is currently dependent upon the fact that bz_get_index_def uses the
field name and NOT the index name. In fact, this is an error in coding that
pre-dates my movement of those functions, which I fixed only recently.

That is, before, the function used the name of the index, because *the name was
the same as the column*. So various mistakes were made in this area that caused
me to have to shift the function to using the column name, in order to make
checksetup continue to work properly with named indexes.

Until bug 284850 checks in, the names of indexes won't be consistent across
databases.

Once that's checked in, we can either fix this (and change every call to
bz_get_index_def in checksetup) or wait for the completion of bug 285111, where
I'll have to change every call to every schema-checking/changing function in all
of checksetup anyhow.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

"If it's not a regression from 2.18 and it's not a critical problem with
something that's already landed, let's push it off." - Dave

Comment 3

[Max Kanat-Alexander]

We no longer use bz_get_index_def, so this is fixed. :-D