287380 - default browser menu doesn't include self

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Vicki Brown]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050322 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050322 Camino/0.8+

I downloaded the latest Camino Nightly Build yesyetrday (2005032208 (v0.8+)) and
noticed that the "Default Browser" menu in the Preferences doesn't list Camino. 

I would have expected it to list itself. :-)


Reproducible: Always

Comment 1

[Mike Pinkerton (not reading bugmail)]

-> josh

Comment 2

[Mike Pinkerton (not reading bugmail)]

really this time.

Comment 3

[Josh Aas]

This bug is documented in the default browser code - the problem is that Launch
Services says org.mozilla.navigator is a web browser, but when we ask Launch
Services to tell us where the application for that bundle ID is, it has no idea
even though its obviously a currently running application. Silliness. We'll have
to add some way to use the currently running copy of Camino if launch services
can't find one.

Comment 4

[Mike Pinkerton (not reading bugmail)]

how common is this? i mean, doesn't it sorta make the entire feature useless?

Comment 5

[Simon Fraser [no longer active]]

I thought there was code to ensure that camino was always in the list?

Comment 6

[Josh Aas]

Camino is always in the browser list, but that doesn't mean Launch Services can
find it. Launch Services might not be finding any number of applications it
gives us, and sometimes that includes Camino (however stupid). So - if LS can
find Camino, this will work. If it can't, this won't. And yes - it makes the
feature useless when LS can't find Camino. So what I'm saying is we need to add
code to substitute the running Camino when LS can't find it.

Comment 7

[Josh Aas]

Attachment: fix v1.0

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 178530 [details] [diff] [review]
fix v1.0

Would be good to know why Launch Services is failing though. What error is
returned?

Comment 9

[Josh Aas]

I can't repro right now, so I can't tell you. I assume it is failing because I
was shuffling around copies of Camino and it simply lost track of the app path.

Comment 10

[Josh Aas]

landed on trunk