287387 - User mode changes always appear in current view, regardless of network

Status: RESOLVED FIXED

Description

[Rob Marshall [tH]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320 Firefox/1.0+
Build Identifier: Chatzilla 0.9.67

The onUserMode function in handlers.js uses display() instead of this.display().

Reproducible: Always

Steps to Reproduce:
1. Connect to two networks.
2. Do the command "/mode (your nick) +i".
3. Quickly swap to a tab from a different network.

Actual Results:  
The user mode message appears in the current view, so it's hard to tell which
network the message came from.

Expected Results:  
The message should always appear in a view of the correct network.

Comment 1

[Rob Marshall [tH]]

Created attachment 178366 [details] [diff] [review]
mini patch

Comment 2

[Robert Ginda]

Comment on attachment 178366 [details] [diff] [review]
mini patch

The MT_MODE line should be indented to appear under the character after the
previous open paren, as in...

this.display(getMsg...
	     MT_MODE);

Other than that, r=rginda

Comment 3

[Samuel Sieb]

Comment on attachment 178366 [details] [diff] [review]
mini patch

>+        this.display(getMsg(MSG_USER_MODE, [e.user.unicodeName, e.params[2]]),
>+            MT_MODE);

The second line should be lined up under the first parameter.
See http://hacksrus.com/~ginda/pedant.html

Comment 4

[Rob Marshall [tH]]

Created attachment 178379 [details] [diff] [review]
patch 2

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 178379 [details] [diff] [review]
patch 2

a=asa

Comment 6

[James Ross]

Checked in --> FIXED.

Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will
include this shortly.