User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320 Firefox/1.0+ Build Identifier: Chatzilla 0.9.67 The onUserMode function in handlers.js uses display() instead of this.display(). Reproducible: Always Steps to Reproduce: 1. Connect to two networks. 2. Do the command "/mode (your nick) +i". 3. Quickly swap to a tab from a different network. Actual Results: The user mode message appears in the current view, so it's hard to tell which network the message came from. Expected Results: The message should always appear in a view of the correct network.
Comment on attachment 178366 [details] [diff] [review] mini patch The MT_MODE line should be indented to appear under the character after the previous open paren, as in... this.display(getMsg... MT_MODE); Other than that, r=rginda
Attachment #178366 - Flags: review?(rginda) → review+
Comment on attachment 178366 [details] [diff] [review] mini patch >+ this.display(getMsg(MSG_USER_MODE, [e.user.unicodeName, e.params]), >+ MT_MODE); The second line should be lined up under the first parameter. See http://hacksrus.com/~ginda/pedant.html
Attachment #178366 - Flags: review+ → review-
Created attachment 178379 [details] [diff] [review] patch 2
Comment on attachment 178379 [details] [diff] [review] patch 2 a=asa
Attachment #178379 - Flags: approval1.8b2? → approval1.8b2+
Checked in --> FIXED. Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will include this shortly.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.