User mode changes always appear in current view, regardless of network

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Rob Marshall [tH], Assigned: Robert Ginda)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-patch][cz-0.9.68])

Attachments

(1 attachment, 1 obsolete attachment)

1.14 KB, patch
Samuel Sieb
: review+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320 Firefox/1.0+
Build Identifier: Chatzilla 0.9.67

The onUserMode function in handlers.js uses display() instead of this.display().

Reproducible: Always

Steps to Reproduce:
1. Connect to two networks.
2. Do the command "/mode (your nick) +i".
3. Quickly swap to a tab from a different network.

Actual Results:  
The user mode message appears in the current view, so it's hard to tell which
network the message came from.

Expected Results:  
The message should always appear in a view of the correct network.
(Reporter)

Comment 1

13 years ago
Created attachment 178366 [details] [diff] [review]
mini patch

Updated

13 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Updated

13 years ago
Attachment #178366 - Flags: review?(rginda)
(Assignee)

Comment 2

13 years ago
Comment on attachment 178366 [details] [diff] [review]
mini patch

The MT_MODE line should be indented to appear under the character after the
previous open paren, as in...

this.display(getMsg...
	     MT_MODE);

Other than that, r=rginda
Attachment #178366 - Flags: review?(rginda) → review+

Comment 3

13 years ago
Comment on attachment 178366 [details] [diff] [review]
mini patch

>+        this.display(getMsg(MSG_USER_MODE, [e.user.unicodeName, e.params[2]]),
>+            MT_MODE);

The second line should be lined up under the first parameter.
See http://hacksrus.com/~ginda/pedant.html
Attachment #178366 - Flags: review+ → review-
(Reporter)

Comment 4

13 years ago
Created attachment 178379 [details] [diff] [review]
patch 2
Attachment #178366 - Attachment is obsolete: true
Attachment #178379 - Flags: review?(samuel)

Updated

13 years ago
Attachment #178379 - Flags: review?(samuel) → review+

Updated

13 years ago
Whiteboard: cz-patch

Updated

13 years ago
Attachment #178379 - Flags: approval1.8b2?

Comment 5

13 years ago
Comment on attachment 178379 [details] [diff] [review]
patch 2

a=asa
Attachment #178379 - Flags: approval1.8b2? → approval1.8b2+

Comment 6

13 years ago
Checked in --> FIXED.

Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will
include this shortly.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: cz-patch → [cz-patch][cz-0.9.68]
You need to log in before you can comment on or make changes to this bug.