287393 - The recurrences "Forever" radio button should be false by default, and only true when set by user or eventDialog.js

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Jeremy Teo]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7.6) Gecko/20050301 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7.6) Gecko/20050301 Firefox/1.0.1

The recurrences "Forever" radio button should be false by default for the event
dialog. It should only be set true by the user, or eventDialog.js


Reproducible: Always

Steps to Reproduce:
1.Create an event that recurrs 2 times
2.Save it
3.Double-click to edit it


Actual Results:  
Both "Forever" and "Repeat number of times" radio buttons are enabled


Expected Results:  
Only "Repeat number of times" should be enabled and set to 2.

Comment 1

[Jeremy Teo]

Attachment: Trivial fix for bug

Just make the "Forever" radio button false by default.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 178374 [details] [diff] [review]
Trivial fix for bug

why not just remove the 'selected' attribute?

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

actually, i think the radio should be set to something for new events and event
that don't have recurrence specified. Otherwise it might stay empty, which is an
error. (and radioboxes just always need to have exactly one item selected. one,
not zero)

Comment 4

[Jeremy Teo]

Attachment: Use JS to select the correct radio button

Fix eventDialog.js to set at any one time only 1 radio button for recurrences
("Forever", "Number of Times", and "Until")

Comment 5

[Jeremy Teo]

Attachment: Use JS to set the correct radio button. Add helper functions for radio groups

Use JS to set 1 out of 3 radio buttons. Added new helper function for radio
groups,
radioGroupSelectItem() so that manipulating radio groups becomes easier as we
add more radio buttons to said group. Thanks to mvl for suggestions.

Comment 6

[Joey Minta]

I'm pretty sure this report is a duplicate of bug 268451.  Jeremy, I understand
if you want to keep this open because of your patch on it, but it might be
better to move things over to that bug.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

No, just keep this one open. This one has way more information, like a patch

Comment 8

[Simon Paquet [:sipaq]]

*** Bug 268451 has been marked as a duplicate of this bug. ***

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 179587 [details] [diff] [review]
Use JS to set the correct radio button. Add helper functions for radio groups

r=mvl

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Patch checked in (with some whitespace changes, to kill tabs)

Comment 11

[Joey Minta]

Re-opening bug.  I'm having serious problems with this patch in 1 Aug nightly.

When editting an event that has already been set to recur until a certain date I
get:
i is not defined
for applicationUtils, line 375.

The problem is worse though.  Fixing i to be item results in no item be selected
when a recuring event is editted.  If 'Until' isn't selected again, the onOK
will fail with the ever pleasant: "flushItem DB error: not an error"

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: clean up my mess

Ehm, i messed up somewhat. I didn't check what the function returns. This patch
should fix it.

Comment 13

[Joey Minta]

Comment on attachment 191252 [details] [diff] [review]
clean up my mess

Much better.  Makes bug 302986 disappear too, for me.  I'll let myk confirm
though.

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 15

[Myk Melez [:myk] [@mykmelez]]

*** Bug 302986 has been marked as a duplicate of this bug. ***