287465 - We should implement the GetSVGDocument interface for HTMLObjectElement/HTMLIFrameElement

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We should probably implement the GetSVGDocument interface for HTMLObjectElement.
We implemented this interface for HTMLEmbedElement in bug 281741.

Comment 1

[Robert Longson [:longsonr]]

*** Bug 319447 has been marked as a duplicate of this bug. ***

Comment 2

[Takeshi Kurosawa :takenspc]

Acid3 test expects |getSVGDocument| for both |iframe| and |object|.

Comment 3

[Jonathan Watt [:jwatt]]

Bah, that's lame. How hard is it to do:

  var doc = iframe.contentDocument || iframe.getSVGDocument();

There are tons of far more critical bugs with no such workaround. IMO acid tests should focus on some of them.

Besides that, the SVG WG seems to have agreed to deprecate getSVGDocument, which was always a crappy interface addition to objects outside of the control of the SVG spec.

Comment 4

[Jeff Walden [:Waldo]]

It may or may not be too late to get that changed; I'd suggest telling Hixie this.  He's usually on #whatwg on freenode and typically in #developers.

The claim is he doesn't read bugmail, but it can't hurt to CC him if he happens to be doing so.

Comment 5

[Jonathan Watt [:jwatt]]

Yup, I'm planning to.

Note he's also the "QA Contact" for this bug, so he'll already be getting the bugmail. ;-)

Comment 6

[Hixie (not reading bugmail)]

The test for it was submitted by a SVGWG member, so...

I don't mind making it optional, I guess, if it really is to be taken out of the spec.

Comment 7

[Robert Longson [:longsonr]]

http://lists.w3.org/Archives/Public/www-svg/2008Feb/0060.html

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: just do it

We might as well just pluck this low-hanging fruit.

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 324947 [details] [diff] [review]
just do it

Looks good.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 11

[Oleg Romashin (:romaxa)]

Seems some files are missing...

mozilla/content/html/content/src/nsHTMLIFrameElement.cpp:39:34: nsIDOMGetSVGDocument.h: No such file or directory
mozilla/content/html/content/src/nsHTMLIFrameElement.cpp:41:31: nsIDOMSVGDocument.h: No such file or directory

Comment 12

[Boris Zbarsky [:bzbarsky]]

Those includes should be #ifdef MOZ_SVG, no?

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah!

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

romaxa, can you patch this?

Comment 15

[Oleg Romashin (:romaxa)]

https://bugzilla.mozilla.org/show_bug.cgi?id=440975