287523 - insensitive check/radio buttons can't be distinguished in some themes

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Ginn Chen]

http://cita.disability.uiuc.edu/mozilla/ts-test-page-input.html#mixed

Disabled check/radio buttons look exactly like enabled radio buttons under these
themes:

Crux theme
Grand Canyon
Mist
Ocean Dream
Simple
Smokey Blue

Comment 1

[Ginn Chen]

Attachment: patch

The toggle button appearance is derived from the underlying GTK theme. Most
themes, when a gtk_paint_option or gtk_paint_check is issued with a valid
widget as a parameter (as is the case in Mozilla), use the widget as the base
for the parameters of the rendered object, including its state (sensitive or
not). In the Mozilla calls, the state is passed separately but the widget is
left as normal all the time, resulting in it being rendered identically
regardless of its state under some theme engines.

Comment 2

[Ginn Chen]

Oops, the reproduce steps work for Sun Mozilla 1.7 but not mozilla.org trunk.
Because we don't use gnome native look&feel for HTML content.

We can use xul file instead for testing.
And bug 264164 may block this one.

Comment 3

[Christopher Blizzard (:blizzard)]

Comment on attachment 178454 [details] [diff] [review]
patch

I'm not doing reviews at the moment, you should be asking bryner for review.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 178454 [details] [diff] [review]
patch

Using gtk_widget_set_sensitive can cause an extra paint of the widget.	Use
GTK_WIDGET_SET_FLAGS instead, with the flag GTK_SENSITIVE.

Comment 5

[Ginn Chen]

Attachment: patch v2

This patch works for me after applying patch of bug 264164

Comment 6

[Ginn Chen]

Fixed on trunk

Checking in gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.16; previous revision: 1.15
done

Comment 7

[Ginn Chen]

Checking in gtk2drawing.c;
/cvsroot/mozilla/gfx/src/gtk/Attic/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.15.8.2; previous revision: 1.15.8.1
done