Closed Bug 287523 Opened 19 years ago Closed 19 years ago

insensitive check/radio buttons can't be distinguished in some themes

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

http://cita.disability.uiuc.edu/mozilla/ts-test-page-input.html#mixed

Disabled check/radio buttons look exactly like enabled radio buttons under these
themes:

Crux theme
Grand Canyon
Mist
Ocean Dream
Simple
Smokey Blue
Attached patch patch (obsolete) — Splinter Review
The toggle button appearance is derived from the underlying GTK theme. Most
themes, when a gtk_paint_option or gtk_paint_check is issued with a valid
widget as a parameter (as is the case in Mozilla), use the widget as the base
for the parameters of the rendered object, including its state (sensitive or
not). In the Mozilla calls, the state is passed separately but the widget is
left as normal all the time, resulting in it being rendered identically
regardless of its state under some theme engines.
Attachment #178454 - Flags: superreview?(bryner)
Oops, the reproduce steps work for Sun Mozilla 1.7 but not mozilla.org trunk.
Because we don't use gnome native look&feel for HTML content.

We can use xul file instead for testing.
And bug 264164 may block this one.
Status: NEW → ASSIGNED
Depends on: 264164
Attachment #178454 - Flags: superreview?(bryner)
Attachment #178454 - Flags: superreview?(blizzard)
Attachment #178454 - Flags: review?(blizzard)
Comment on attachment 178454 [details] [diff] [review]
patch

I'm not doing reviews at the moment, you should be asking bryner for review.
Attachment #178454 - Flags: superreview?(bryner)
Attachment #178454 - Flags: superreview?(blizzard)
Attachment #178454 - Flags: review?(bryner)
Attachment #178454 - Flags: review?(blizzard)
Comment on attachment 178454 [details] [diff] [review]
patch

Using gtk_widget_set_sensitive can cause an extra paint of the widget.	Use
GTK_WIDGET_SET_FLAGS instead, with the flag GTK_SENSITIVE.
Attachment #178454 - Flags: superreview?(bryner)
Attachment #178454 - Flags: superreview-
Attachment #178454 - Flags: review?(bryner)
Attachment #178454 - Flags: review-
Attached patch patch v2Splinter Review
This patch works for me after applying patch of bug 264164
Attachment #178454 - Attachment is obsolete: true
Attachment #194282 - Flags: superreview?(bryner)
Attachment #194282 - Flags: review?(bryner)
Attachment #194282 - Flags: superreview?(bryner)
Attachment #194282 - Flags: superreview+
Attachment #194282 - Flags: review?(bryner)
Attachment #194282 - Flags: review+
Fixed on trunk

Checking in gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.16; previous revision: 1.15
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #194282 - Flags: approval1.8b5?
Attachment #194282 - Flags: approval1.8b5? → approval1.8b5+
Checking in gtk2drawing.c;
/cvsroot/mozilla/gfx/src/gtk/Attic/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.15.8.2; previous revision: 1.15.8.1
done
Keywords: fixed1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: