287684 - UTF-8 chars incorrectly displayed on the dependency graph

Status: RESOLVED WORKSFORME

(Bugzilla :: Dependency Views, defect)

Description

[Roman Pszonka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421 MultiZilla/1.6.3.1d
Build Identifier: 

If you have summary with UTF-8 extended characters, they are not correctly
displayed on the dependency graph. 

Reproducible: Always

Steps to Reproduce:
1. choose bug with UTF-8 extended chars in the summary
2. click 'Show dependency graph' link
3. mark 'Show the summaries of all displayed bugs' and click 'Change Parameters'
to update graph
Actual Results:  
UTF-8 chars are broken.

Expected Results:  
UTF-8 chars should be displayed correctly.

According to http://www.graphviz.org/bugs/b418.html, "graphviz supports utf-8
via libgd", so this bug may be related to bug 287682.

Comment 1

[Roman Pszonka]

If you are going to switch to UTF-8 in 2.20 (bug 126266), it would be nice to
display all UTF-8 characters correctly

Comment 2

[Dave Miller [:justdave]]

bug 126266 which is a prerequisite for this has already missed the boat for
2.20, pushing this back accordingly.

Confirming, I can reproduce this on landfill even with all the UTF8 stuff applied. 

Comment 3

[A. Shimono [:himorin]]

only you need to do is 'add entry of suitable font into the template'.
like

diff -r1.65 showdependencygraph.cgi
123c123
< node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey]
---
> node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey, fontsize=12, fontname="/usr/share/fonts/ja/TrueType/kgsub.ttf"]

kgsub.ttf includes griphs for Japanese.
you can check here: http://bugzilla-trunk.test.mozilla.gr.jp/showdependencygraph.cgi?id=5555&showsummary=on&display=tree&rankdir=TB

mkanat: is it possible to add a param for this thing?

Comment 4

[Max Kanat-Alexander]

(In reply to comment #3)
> mkanat: is it possible to add a param for this thing?

  Yeah, maybe. We could also ship or give installation instructions for a Unicode font like DejaVu that contains all the Unicode glyphs. Do you know if that would be possible, or if the license would work for us?

Comment 5

[A. Shimono [:himorin]]

i think we can ship bugzilla with dejavu. But, i don't think we can satisfy all requirements by that.
i'd prefer, rather than to include font files, to add a parameter for specifing system font. b/c
* fontname must be specified in 'full path'
* fontname must not contain _ or - or so.
* font file with completely all unicode glyphs might be huge...

dejavu is based on bitstream vera font etc. which could be published with copyright and trademark notice. (also included in debian http://packages.debian.org/etch/ttf-dejavu)
DejaVu : http://dejavu.sourceforge.net/wiki/index.php/License
bitstream : http://www.gnome.org/fonts/#Final_Bitstream_Vera_Fonts

i've changed the font of the url at comment #3 to DejaVu's.
All Japanese strings are shown with square :p

cf.
> Most DejaVu fonts are suitable for Latin (Western and Central European, African 
> Latin and International Phonetic alphabets), Cyrillic (European) and Greek 
> (Modern and Polytonic). Arabic, Armenian, Hebrew, Lao, Canadian Aboriginal 
> Syllabics and Georgian are currently in development and included in DejaVu 
> Sans.

Comment 6

[Alexey Gaidukov]

Bugzilla 3.0.3, Windows Server 2003 R2, Graphviz-win v2.16

Applied https://bugzilla.mozilla.org/attachment.cgi?id=314555 himorin's patch.

UTF-8 symbols are displayed correctly.

graphfontname=c:\windows\fonts\Arial.ttf

Comment 7

[Frédéric Buclin]

UTF8 characters are correctly displayed. No need to patch anything.