287709 - throbber (progress spinner) in toolbar has no inactive state

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, enhancement)

Description

[Jamie Diamond]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20050323 Camino/0.8.2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20050323 Camino/0.8.2

This is one firefox feature that would really help in camino. The spinning page
load icon in the top right corner of the window does not indicate weather it is
active or static, and since when it is active, it moves slowly, people with
lower vision have no way to pick up on weather a page is loading or not without
getting very close, whcih is an unbearable chore for them after a while.

Reproducible: Always

Comment 1

[Mike Pinkerton (not reading bugmail)]

what about the progress bar in the status bar? are you talking about after you
add the throbber to the toolbar?

Comment 2

[Jamie Diamond]

This is purley about the toolbar throbber. It's useless to put it there if some
people don't know when it's in use. It's also a chore to look at the bottom of
the page everytime, that's why the throbber is implemented in the first place.

Comment 3

[Mike Pinkerton (not reading bugmail)]

agreed, there is already another bug about overhauling the throbber (or just
getting rid of it). this isn't something of very high priority.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I would argue, however, that the throbber has no *inactive* state.  The system
progress spinner "disappears" when it is not active, making the distinction
between in-progress, stalled, and doing nothing very clear, whereas the Camino
throbber's default (doing nothing) frame looks very much like an
in-progressed/stalled situation, given how light/difficult to distinguish it is.

(I like the throbber at the top, too, because it's much more natural to look at
the top, like the lock/yellow URL bg, and it's at just the right height/eye-level.)

See bug 162353 and bug 152292 about throbber redesign.

Comment 5

[Jamie Diamond]

These bugs are more about the technical implementation than on actual design of it. If an active state 
throbber can be made, great; but if one cannot, it should just dissapear without yeilding sapce when it's 
not active.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This isn't really fixable until we do bug 318786.

*** This bug has been marked as a duplicate of 318786 ***

Comment 7

[froodian (Ian Leue)]

This isn't really a dupe - more of a dep.

Comment 8

[R P Mozley]

Attachment: Throbber inactive

Here is the custom throbber image that is only 27% of the original transparency.
Patch to invoke image in -stopThrobber function follows...

Comment 9

[R P Mozley]

Attachment: Throbber inactive image patch

Patch to invoke custom throbber inactive image.

Comment 10

[R P Mozley]

I have already successfully tested the patch in a custom build I made the other day (and am actually using it right now). RPM.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

R P Mozley, can you make this into a real patch (from cvs)?  http://wiki.caminobrowser.org/Development:Reviewing#Proper_patch_format

Comment 12

[R P Mozley]

Umm... No, I don't think I can do that. I'm not too sure what I'm suppose to do, from reading that info on "Proper patch format". I've never really used cvs before, well not for anything like that. Sorry I can't really help in that respect. RPM.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: patch for R P Mozley's change

With some help from cl tonight, I found where the line that needed to be modified had moved, so here's a real patch.  I have no idea who should review, but cl's queue looks fairly empty.

If we like this method, I'll whip up a project patch to go along later.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: inactive state throbber, reduced in size

Here's the inactive state throbber image, only less bloated.  I'd sorta like to see all the rays(?) uniform in color, but this is so much of an improvement I'll be OK if the consensus is to just use this as-is.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Comparison shot

Current is on the right, R P Mozley's new version on the right.

Comment 16

[Chris Lawson (gone)]

Comment on attachment 270409 [details] [diff] [review]
patch for R P Mozley's change

Looks good here. r=me.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 270409 [details] [diff] [review]
patch for R P Mozley's change

mento expressed interest in getting the inactive throbber state fixed, so maybe he'll want to sr this 1-liner?

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This needs a project patch to add throbber-00 to the project.  

I think we're close enough to the project switchover that I don't want to do one now and bitrot smorgan's project re-org work that's coming with the switchover.

Comment 19

[Chris Lawson (gone)]

Attachment: trunk project path

Trunk project patch. File needs to be renamed with .tif extension on checkin for consistency (which this patch assumes).

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

cl's going to respin the trunk patch due to bitrot and work up a branch one.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: combined trunk patch

project change+code, for checkin

Comment 22

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: combined branch patch

same as above for branch

Comment 23

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: inactive state throbber, reduced in size, with correct name

throbber image with the proper name, for ease of checkin

Comment 24

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk and the MOZILLA_1_8_BRANCH.  Thanks for the patch and image, R P Mozley!