287826 - fix PreFast warnings in layout/generic

Status: NEW

(Core :: Layout, defect)

Description

[Bernd]

e:\moz_src\mozilla\layout\generic\nsFrame.cpp (910): warning 246: Local
declaration of 'rect' hides declaration of the same name in an outer scope:  see
previous declaration at line 896 of e:\moz_src\mozilla\layout\generic\nsFrame.cpp.
	FUNCTION: nsFrame::Paint (831)
	PATH: 896 

e:\moz_src\mozilla\layout\generic\nsFrame.cpp (4188): warning 246: Local
declaration of 'result' hides declaration of the same name in an outer scope: 
see previous declaration at line 4011 of
e:\moz_src\mozilla\layout\generic\nsFrame.cpp.
	FUNCTION: nsFrame::GetFrameFromDirection (4005)
	PATH: 4011 

e:\moz_src\mozilla\layout\generic\nsFrame.cpp (5989): warning 204: Possible
buffer overrun in call to 'strcpy':  use of unchecked parameter 'aFrameNameAbbrev'.
	FUNCTION: DR_FrameTypeInfo::__ctor (5984)
	PATH: 

e:\moz_src\mozilla\layout\generic\nsFrame.cpp (5990): warning 204: Possible
buffer overrun in call to 'strcpy':  use of unchecked parameter 'aFrameName'.
	FUNCTION: DR_FrameTypeInfo::__ctor (5984)
	PATH: 

e:\moz_src\mozilla\layout\generic\nsframesetframe.cpp (404): warning 246: Local
declaration of 'result' hides declaration of the same name in an outer scope: 
see previous declaration at line 353 of
e:\moz_src\mozilla\layout\generic\nsframesetframe.cpp.
	FUNCTION: nsHTMLFramesetFrame::Init (305)
	PATH: 353 

1 of 1 Defect Listed
e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp (1185): warning 246:
Local declaration of 'x' hides declaration of the same name in an outer scope: 
see previous declaration at line 1173 of
e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp.
	FUNCTION: nsGfxScrollFrameInner::ScrollToRestoredPosition (1161)
	PATH: 1173 

e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp (1185): warning 246:
Local declaration of 'y' hides declaration of the same name in an outer scope: 
see previous declaration at line 1174 of
e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp.
	FUNCTION: nsGfxScrollFrameInner::ScrollToRestoredPosition (1161)
	PATH: 1174 

e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp (2225): warning 1: Using
uninitialized memory 'h'.
	FUNCTION: nsGfxScrollFrameInner::RestoreState (2198)
	PATH: 2200 2201 2202 2203 2204 2205 2206 2207 2209 2210 2210 2210 2210 2211
2212 2213 2214 2215 2216 2219 2220 2221 2224 2225 

e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp (2225): warning 1: Using
uninitialized memory 'w'.
	FUNCTION: nsGfxScrollFrameInner::RestoreState (2198)
	PATH: 2200 2201 2202 2203 2204 2205 2206 2207 2209 2210 2210 2210 2210 2211
2212 2213 2214 2216 2217 2219 2220 2221 2224 2225 

e:\moz_src\mozilla\layout\generic\nsgfxscrollframe.cpp (2225): warning 1: Using
uninitialized memory 'y'.
	FUNCTION: nsGfxScrollFrameInner::RestoreState (2198)
	PATH: 2200 2201 2202 2203 2204 2205 2206 2207 2209 2210 2210 2210 2210 2211
2212 2214 2215 2216 2217 2219 2220 2221 2224 2225 

e:\moz_src\mozilla\layout\generic\nsimageframe.cpp (1431): warning 246: Local
declaration of 'map' hides declaration of the same name in an outer scope:  see
previous declaration at line 1417 of
e:\moz_src\mozilla\layout\generic\nsimageframe.cpp.
	FUNCTION: nsImageFrame::Paint (1292)
	PATH: 1417 

1 of 1 Defect Listed
e:\moz_src\mozilla\layout\generic\nssimplepagesequence.cpp (929): warning 246:
Local declaration of 'rv' hides declaration of the same name in an outer scope:
 see previous declaration at line 924 of
e:\moz_src\mozilla\layout\generic\nssimplepagesequence.cpp.
	FUNCTION: nsSimplePageSequenceFrame::DoPageEnd (922)
	PATH: 924 

1 of 1 Defect Listed
e:\moz_src\mozilla\layout\generic\nstextframe.cpp (1901): warning 1: Using
uninitialized memory 'overColor'.
	FUNCTION: nsTextFrame::PaintTextDecorations (1826)
	PATH: 1841 1842 1842 1842 1844 1845 1847 1849 1852 1853 1855 1894 1895 1896
1897 1899 1900 1901 

e:\moz_src\mozilla\layout\generic\nstextframe.cpp (1905): warning 1: Using
uninitialized memory 'underColor'.
	FUNCTION: nsTextFrame::PaintTextDecorations (1826)
	PATH: 1841 1842 1842 1842 1844 1845 1847 1849 1852 1853 1855 1894 1895 1896
1897 1899 1900 1901 1902 1904 1905 

e:\moz_src\mozilla\layout\generic\nstextframe.cpp (1911): warning 1: Using
uninitialized memory 'strikeColor'.
	FUNCTION: nsTextFrame::PaintTextDecorations (1826)
	PATH: 1841 1842 1842 1842 1844 1845 1847 1849 1852 1853 1855 1894 1895 1896
1897 1899 1900 1901 1902 1904 1905 1906 1909 1910 1911 

e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp (593): warning 246:
Local declaration of 'rv' hides declaration of the same name in an outer scope:
 see previous declaration at line 571 of
e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp.
	FUNCTION: nsTextTransformer::ScanNormalUnicodeText_F (525)
	PATH: 571 

e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp (1153): warning 246:
Local declaration of 'ch' hides declaration of the same name in an outer scope:
 see previous declaration at line 1145 of
e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp.
	FUNCTION: nsTextTransformer::ScanNormalAsciiText_B (1138)
	PATH: 1145 

e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp (1150): warning 328:
'unsigned short' passed as parameter 1 when 'unsigned char' is required in call
to 'isalnum'.
	FUNCTION: nsTextTransformer::ScanNormalAsciiText_B (1138)
	PATH: 

e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp (1164): warning 328:
'unsigned short' passed as parameter 1 when 'unsigned char' is required in call
to 'isalnum'.
	FUNCTION: nsTextTransformer::ScanNormalAsciiText_B (1138)
	PATH: 

e:\moz_src\mozilla\layout\generic\nstexttransformer.cpp (1169): warning 328:
'unsigned short' passed as parameter 1 when 'unsigned char' is required in call
to 'isalnum'.
	FUNCTION: nsTextTransformer::ScanNormalAsciiText_B (1138)
	PATH:

Comment 1

[Bernd]

Attachment: raw patch