Closed Bug 288004 Opened 19 years ago Closed 19 years ago

JS properties on DOM attributes should be preserved across GCs

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: peterv)

References

Details

Attachments

(1 file)

JS properties added to DOM attribute objects are not currently preserved across
garbage collection.  Once bug 283129 and bug 235512 are fixed, this could be
fixed pretty easily by modifying GetSCCRootFor (added in bug 283129) to return
the correct root for attributes.  (Essentially, it just needs to get the element
from the attribute and then call itself on the element.)
Attached patch v1Splinter Review
Like this?
Assignee: general → peterv
Status: NEW → ASSIGNED
Attachment #193045 - Flags: review?(dbaron)
Oy.  I should probably land some of the changes in bug 241518, which would make
this a good bit cleaner.
Comment on attachment 193045 [details] [diff] [review]
v1

r=dbaron, although I don't see the reason to remove the attribute printing code
for elements, which made it much easier to figure out what was involved
(usually id attributes in XUL).

Also, local style is "} else {" all on one line.
Attachment #193045 - Flags: review?(dbaron) → review+
(In reply to comment #3)
> Oy.  I should probably land some of the changes in bug 241518, which would make
> this a good bit cleaner.

Ah, hmm, so should I still land this?
Yeah, go ahead.  I've changed the patch for bug 241518 that I have in one of my
trees.
Attachment #193045 - Flags: superreview?(jst)
Comment on attachment 193045 [details] [diff] [review]
v1

sr=jst
Attachment #193045 - Flags: superreview?(jst) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: