288004 - JS properties on DOM attributes should be preserved across GCs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

JS properties added to DOM attribute objects are not currently preserved across
garbage collection.  Once bug 283129 and bug 235512 are fixed, this could be
fixed pretty easily by modifying GetSCCRootFor (added in bug 283129) to return
the correct root for attributes.  (Essentially, it just needs to get the element
from the attribute and then call itself on the element.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 283129 comment 23, bug 283129 comment 24, and bug 283129 comment 26.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

Like this?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oy.  I should probably land some of the changes in bug 241518, which would make
this a good bit cleaner.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 193045 [details] [diff] [review]
v1

r=dbaron, although I don't see the reason to remove the attribute printing code
for elements, which made it much easier to figure out what was involved
(usually id attributes in XUL).

Also, local style is "} else {" all on one line.

Comment 5

[Peter Van der Beken [:peterv]]

(In reply to comment #3)
> Oy.  I should probably land some of the changes in bug 241518, which would make
> this a good bit cleaner.

Ah, hmm, so should I still land this?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, go ahead.  I've changed the patch for bug 241518 that I have in one of my
trees.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 193045 [details] [diff] [review]
v1

sr=jst