coverity uninitialized variable warnings in layout

RESOLVED FIXED in mozilla1.8beta2

Status

()

P2
normal
RESOLVED FIXED
14 years ago
2 months ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla1.8beta2
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

The coverity tool warns about some uninitialized variables.  Patch coming.
Created attachment 178869 [details] [diff] [review]
patch

Bernd, I'd be interested in thoughts on what to do in the last bit, or whether
the null-check should be there at all.
Attachment #178869 - Flags: superreview?(roc)
Attachment #178869 - Flags: review?(bernd.mielke)
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
Attachment #178869 - Flags: superreview?(roc) → superreview+

Comment 2

14 years ago
Comment on attachment 178869 [details] [diff] [review]
patch

A null check on bcdata is a check for a cellmap hole.

A cellmap hole happens when row- or colspans are involved just in the following
markup at position 1,2 is a hole.

<tr><td><td><td rowspan="2"></tr>
<tr><td></tr>

These holes are frequent and valid markup so one needs the null check.
As one might guess the border collapse code with its painting of the longest
possible line barfs on cellmap holes (bug 190593)

if the cornersubwidth is 0 all other variables don't play a role so silencing
the warning here in the you proposed is the correct thing to do, I believe (no
XXX necessary IMHO)
Attachment #178869 - Flags: review?(bernd.mielke) → review+
Keywords: coverity
Checked in 2005-03-29 17:50 -0800.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Blocks: 1230156

Updated

2 months ago
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.