288092 - coverity uninitialized variable warnings in layout

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The coverity tool warns about some uninitialized variables.  Patch coming.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Bernd, I'd be interested in thoughts on what to do in the last bit, or whether
the null-check should be there at all.

Comment 2

[Bernd]

Comment on attachment 178869 [details] [diff] [review]
patch

A null check on bcdata is a check for a cellmap hole.

A cellmap hole happens when row- or colspans are involved just in the following
markup at position 1,2 is a hole.

<tr><td><td><td rowspan="2"></tr>
<tr><td></tr>

These holes are frequent and valid markup so one needs the null check.
As one might guess the border collapse code with its painting of the longest
possible line barfs on cellmap holes (bug 190593)

if the cornersubwidth is 0 all other variables don't play a role so silencing
the warning here in the you proposed is the correct thing to do, I believe (no
XXX necessary IMHO)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No effect on bug 190593.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in 2005-03-29 17:50 -0800.