Closed Bug 288092 Opened 15 years ago Closed 15 years ago

coverity uninitialized variable warnings in layout

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [patch])

Attachments

(1 file)

The coverity tool warns about some uninitialized variables.  Patch coming.
Attached patch patchSplinter Review
Bernd, I'd be interested in thoughts on what to do in the last bit, or whether
the null-check should be there at all.
Attachment #178869 - Flags: superreview?(roc)
Attachment #178869 - Flags: review?(bernd.mielke)
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
Attachment #178869 - Flags: superreview?(roc) → superreview+
Comment on attachment 178869 [details] [diff] [review]
patch

A null check on bcdata is a check for a cellmap hole.

A cellmap hole happens when row- or colspans are involved just in the following
markup at position 1,2 is a hole.

<tr><td><td><td rowspan="2"></tr>
<tr><td></tr>

These holes are frequent and valid markup so one needs the null check.
As one might guess the border collapse code with its painting of the longest
possible line barfs on cellmap holes (bug 190593)

if the cornersubwidth is 0 all other variables don't play a role so silencing
the warning here in the you proposed is the correct thing to do, I believe (no
XXX necessary IMHO)
Attachment #178869 - Flags: review?(bernd.mielke) → review+
Keywords: coverity
No effect on bug 190593.
Checked in 2005-03-29 17:50 -0800.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.