288144 - http auth dialog does not show URI

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Anne (:annevk)]

Apparently the Spanish login dialog does not show the URI of the site you are
logging into:
 <http://braintags.com/archives/2005/03/firefox_login_security/>

Comment 1

[Daniel Veditz [:dveditz]]

Sairuh confirmed this with an es-ES linux Firefox 1.0.2

The appropriate translated format string exists in necko.properties and it looks
to me like the nsHttpChannel code would not show the dialog at all if the string
were missing or if adding the realm and host names failed.

The es-ES version of necko.properties is scrambled (compared to the original
source) by the translation tool. Hard to read and find things, but shouldn't
affect how it works.

Clearing security confidential flag: The original report is posted on a public
blog. In addition this is more of an anti-phishing mechanism than a security
one; 1.0.2 was fixed to make sure the auth prompt appears over the correct tab
so the only remaining confusion might be if there were multiple frames on a page.

Comment 2

[Axel Hecht]

It looks like
http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/es-ES/chrome/necko/necko.properties#3

should have a 
Introduzca usuario y contrase\u00F1a para %1$S en %2$S
instead of
Introduzca usuario y contrase\u00F1a para %1 en %2$S

Looking at the code in
http://lxr.mozilla.org/aviarybranch/source/netwerk/protocol/http/src/nsHttpChannel.cpp#2463
and nsTextFormatter, it looks like that a malformed string is going to turn out
empty without returning an error.

Comment 3

[Oscar Manuel Gómez Senovilla]

Attachment: Fix to problema

Comment 4

[Chase Phillips]

Comment on attachment 179445 [details] [diff] [review]
Fix to problema

Clearing approval-aviary1.0.3.	You only need to request approval-l10n for
fixes to locale files.

Comment 5

[Toni Hermoso Pulido]

Patch applied.

Comment 6

[Oscar Manuel Gómez Senovilla]

Closing the bug