288170 - importxml.pl, move.pl should not write to $datadir/maillog

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Olav Vitters]

(I emailed this also to the developers mailinglist where gerv responded that he
had no objections that this should be commented out / removed)

The files importxml.pl and move.pl write to $datadir/maillog. The only thing
written to those files are:
(importxml.pl)
  Log($subject . " sent to: $to");

(move.pl)
  "XML: bugs $buglist sent to $to"

There is also code in BugMail.pm to write to this file but it has been commented
out (even in the initial commit).

I think this code should be removed. It isn't used by BugMail.pm, so why is it
in above files? It is only used to log email activity, but BugMail.pm has it
commented out.

Some background:
At bugzilla.gnome.org we use a forked importxml.pl containing the logging. The
importxml.pl is activated by an email message delivered using Postfix. Postfix
sets the 'file size' ulimit to 50MB (I think it sets it to 5 times the
configured max email message size).
Importxml.pl writes to the log after doing everything else (creating the bug). A
few days ago $datadir/maillog hit that 50MB and importxml.pl aborted. At b.g.o
this causes the message to be forwarded for investigation. This problem is
probably specific, but as the logging does not serve a useful purpose
(BugMail.pm is excluded), I think it should be removed.

As b.g.o will be upgraded to 2.20 I'll also ask this to block 2.20.

Comment 1

[Olav Vitters]

Attachment: Patch v1 against Bugzilla HEAD 29 March 2005

Removes the Log,Lock,Unlock subroutine from importxml.pl and move.pl, Lock and
Unlock are only used by Log.

Comment 2

[Olav Vitters]

Comment on attachment 178940 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 29 March 2005

Patch removes the Log,Lock,Unlock subroutines from importxml.pl and move.pl,
Lock and Unlock are only used by Log.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

"If it's not a regression from 2.18 and it's not a critical problem with
something that's already landed, let's push it off." - Dave

Comment 4

[Frédéric Buclin]

Comment on attachment 178940 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 29 March 2005

bkor asked me to review his patch.

Comment 5

[Frédéric Buclin]

Comment on attachment 178940 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 29 March 2005

looks good. r=LpSolit

Comment 6

[Dave Miller [:justdave]]

we may want this kind of logging at some point, but if we do it we should do it
right and use syslog or something.

Comment 7

[Frédéric Buclin]

tip:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.45; previous revision: 1.44
done
Checking in move.pl;
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.33; previous revision: 1.32
done


2.20rc1:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.44.2.1; previous revision: 1.44
done
Checking in move.pl;
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.31.4.1; previous revision: 1.31
done