Closed Bug 288539 Opened 19 years ago Closed 19 years ago

minimum DBD::mysql version requirement may need to be increased beyond 2.1028

Categories

(Bugzilla :: Administration, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: altlist, Assigned: altlist)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0

I was not able to get checksetup.pl to run cleanly with the latest bugzilla tip.
 The script now uses the new DB::bz_server_version function.

Was able to solve this problem by upgrading my DBD::mysql version from 2.1028 to
the latest (2.9004)

Reproducible: Always

Steps to Reproduce:
No, only to 2.9002.
Depends on: 286527
Whiteboard: [blocker will fix]
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.20
Attached patch patch (obsolete) — Splinter Review
Ok, 2.9002 it is.
Attachment #179302 - Flags: review?(mkanat)
Assignee: administration → altlst
No longer depends on: 286527
Whiteboard: [blocker will fix]
Status: NEW → ASSIGNED
Attachment #179302 - Flags: review?(mkanat) → review+
Flags: approval?
Can bz_server_version be hacked to not require the newer version of DBD::mysql?
*** Bug 289107 has been marked as a duplicate of this bug. ***
Keywords: relnote
Comment on attachment 179302 [details] [diff] [review]
patch

2.9002 doesn't work on windows, throws:

Renaming indexes...
Undefined subroutine &DBD::mysql::db::SQL_INTEGER called at
d:/Perl/site/lib/DBD/mysql.pm line 362

2.9003 works.
Attachment #179302 - Flags: review-
Anyone care to answer Myk's question in comment 3?  Current patch has a denied
review anyway, removing approval request.
Flags: approval?
(In reply to comment #3)
> Can bz_server_version be hacked to not require the newer version of DBD::mysql?

It could be hacked, but I don't think it would be database independent. 
Granted, I don't know where we're at with respect to Postgres support.
We require 2.9003 for many other reasons than bz_server_version. For example,
the new Schema code needs column_info to work properly, and so forth.

2.9003 is *years* old at this point. It's not a big problem, I think.
Attached patch patch v2Splinter Review
Attachment #179302 - Attachment is obsolete: true
Attachment #180827 - Flags: review?(mkanat)
Attachment #180827 - Flags: review?(mkanat) → review+
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.396; previous revision: 1.395
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Added to the release notes in bug 286274.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: